Skip to content

Make the Pen tool use Ctrl to lock the angle of handles such that they maintain colinearity #2284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Feb 17, 2025

Conversation

0SlowPoke0
Copy link
Contributor

@0SlowPoke0 0SlowPoke0 commented Feb 11, 2025

Partly closes #1870

  • Ctrl locks the current angle of the handle (already implemented), but should also work to be colinear with the opposite handle if being dragged out of an existing anchor point, or if that anchor point has no handle then it should use the angle of the actual curve segment entering that handle, i.e. its tangent angle at its endpoint
  • Added feature visualizing the 15° increment locking with Shift discord

Also fixes these bugs:

  • Fixes scaling the handle to zero length rotates the opposite (Discord)
  • Fixes dragging a handle into its anchor make the opposite rotate (Discord)

@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review February 11, 2025 07:17
@Keavon
Copy link
Member

Keavon commented Feb 11, 2025

!build

Copy link

📦 Build Complete for 6dfa839
https://6f86cded.graphite.pages.dev

@0SlowPoke0 0SlowPoke0 marked this pull request as draft February 12, 2025 13:34
@Keavon
Copy link
Member

Keavon commented Feb 14, 2025

!build

Copy link

📦 Build Complete for d7afeb0
https://d0188cce.graphite.pages.dev

@0SlowPoke0 0SlowPoke0 marked this pull request as ready for review February 16, 2025 09:27
@Keavon Keavon changed the title Improve Pen Tool: Ctrl Lock Enforces Colinearity When Extending Handles Make the Pen tool use Ctrl to lock the angle of handles such that they maintain colinearity Feb 16, 2025
@Keavon Keavon merged commit e444785 into GraphiteEditor:master Feb 17, 2025
4 checks passed
@0SlowPoke0 0SlowPoke0 deleted the tab branch February 17, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue: Pen and Path tool improvements
2 participants