Skip to content

Consistant colours for axes #2330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 8 commits into from
Closed

Consistant colours for axes #2330

wants to merge 8 commits into from

Conversation

kuldeeprathore05
Copy link

Closes #2311
Screenshot 2025-02-28 233034

@Keavon
Copy link
Member

Keavon commented Mar 1, 2025

!build

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2025

📦 Build Complete for 9cba0ba
https://51047bd0.graphite.pages.dev

@Keavon
Copy link
Member

Keavon commented Mar 1, 2025

I think you misinterpreted the intention here. The axis-constrained Shift dragging should become blue and green to match the compass rose dragging, not removing all colors from the compass rose. Could you please revert this and try that instead?

@Keavon Keavon marked this pull request as draft March 1, 2025 01:05
@kuldeeprathore05
Copy link
Author

Is this okay?
Screenshot 2025-03-01 112437

@Keavon
Copy link
Member

Keavon commented Mar 1, 2025

Changing the colors of the GRS visualizations will not be necessary. Just the axis-constraint lines when dragging with Shift held.

@kuldeeprathore05
Copy link
Author

@Keavon can you review the PR?
Screenshot 2025-03-01 161630

@Keavon
Copy link
Member

Keavon commented Mar 2, 2025

Thanks, your screenshot looks good. It might be a few days before I can get back to doing code reviews since I tend to do similar things (like landing PRs) in batches.

@kuldeeprathore05 kuldeeprathore05 marked this pull request as ready for review March 21, 2025 11:17
0HyperCube
0HyperCube requested changes Mar 26, 2025
View reviewed changes
Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution; this works well apart from the crash.

editor/src/messages/tool/tool_messages/select_tool.rs

let extension = tool_data.drag_current - tool_data.drag_start;
let origin = compass_center - extension;
let viewport_diagonal = input.viewport_bounds.size().length();

let edge = DVec2::from_angle(snapped_angle) * viewport_diagonal;
let perp = edge.perp();
let edge_dot_horizontal = edge.normalize().dot(DVec2::X).abs();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This crashes when the user moves their mouse exactly over the starting position in debug mode.

drag_crash.mp4

@0HyperCube 0HyperCube marked this pull request as draft March 26, 2025 18:45
@Keavon Keavon force-pushed the master branch 4 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
@Keavon
Copy link
Member

Keavon commented Apr 17, 2025

Closing this out as stale.

@Keavon Keavon closed this Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mTvare6 mTvare6 mTvare6 left review comments

@0HyperCube 0HyperCube 0HyperCube requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consistant colours for axes
4 participants
@kuldeeprathore05 @Keavon @mTvare6 @0HyperCube