Added preference for zoom wheel rate adjustment #2413
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0HyperCube
requested changes
Mar 9, 2025
| @@ -14,6 +14,7 @@ pub struct PreferencesMessageHandler { | |||
| pub use_vello: bool, | |||
| pub vector_meshes: bool, | |||
| pub graph_wire_style: GraphWireStyle, | |||
| pub zoom_wheel_rate: Option<f64>, | |||
There was a problem hiding this comment.
Why is this an option? Is there a case when we'd have a zoom wheel rate of None?
| .min(0.001) | ||
| .max(0.1) | ||
| .on_update(|number_input: &NumberInput| { | ||
| PreferencesMessage::ZoomWheelRate { rate: number_input.value }.into() |
There was a problem hiding this comment.
This doesn't compile:
error[E0308]: mismatched types
--> editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs:68:63
|
68 | PreferencesMessage::ZoomWheelRate { rate: number_input.value }.into()
| ^^^^^^^^^^^^^^^^^^ expected `f64`, found `Option<f64>`
|
Try to fix issue and requested changes |
|
Thanks for showing an interest in contributing to Graphite. Unfortunately, your PRs do not meet the minimum bar for quality as they are untested and do not compile (and chances are high that they are not human-authored) so we won't be considering them further. Best of luck in your future programming journey. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2411