Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix min and max macro not enforcing limits when data flows #2464

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fix min and max macro not enforcing limits when data flows #2464

wants to merge 15 commits into from

Conversation

mTvare6
Copy link
Contributor

@mTvare6 mTvare6 commented Mar 18, 2025

@Keavon Keavon marked this pull request as draft March 20, 2025 08:11
@Keavon
Copy link
Member

Keavon commented Mar 20, 2025

Requires hard/soft range rework discussed in Discord.

@mTvare6
Copy link
Contributor Author

mTvare6 commented Mar 22, 2025

@Keavon I've changed them into hard_min and min(considering it to be the default). Do let me know if it should instead be called soft_min.

@mTvare6 mTvare6 marked this pull request as ready for review March 22, 2025 05:16
@Keavon Keavon force-pushed the master branch 3 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mTvare6 @Keavon @TrueDoctor