Skip to content

Fix mask node upstream input calculation. #2466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

Fix mask node upstream input calculation. #2466

wants to merge 10 commits into from

Conversation

singhutsav5502
Copy link
Contributor

@singhutsav5502 singhutsav5502 commented Mar 18, 2025 •
edited by Keavon
Loading 

Closes #2468
Add Manual composition to mask node.
( wasn't sure if i should club this with another PR. )

singhutsav5502 and others added 10 commits March 11, 2025 16:29
@singhutsav5502
Add InputType based filtering capabilites to NodeCatalog.
56c5a51 
Send InputTypes through SendUiMetadata under
odeTypes.
Update NodeCatalog.svelte component to support 	ype based filtering.
Update ContextMenuData to support compatibleType as an input to the searchTerm for the NodeCatalog.
Update Graph.svelte component to support new ContextMenuData enum types.
Send CompatibleType data from rust backend on wire drag and release to NodeCatalog to already show filtered data.
@singhutsav5502
Add InputType based filtering capabilites to NodeCatalog.
09a7d66 
Send InputTypes through SendUiMetadata under
odeTypes.
Update NodeCatalog.svelte component to support 	ype based filtering.
Update ContextMenuData to support compatibleType as an input to the searchTerm for the NodeCatalog.
Update Graph.svelte component to support new ContextMenuData enum types.
Send CompatibleType data from rust backend on wire drag and release to NodeCatalog to already show filtered data.
@singhutsav5502
Merge branch 'filter-node-catalog' of github.com:singhutsav5502/Graph…
ba643f7 
…ite into filter-node-catalog
@singhutsav5502
Open NodeCatalog on DoubleClick in empty node graph area
ef0dc90
@Keavon
Merge branch 'master' into filter-node-catalog
4528a8c
@singhutsav5502
Capture Node implementations and filter out uncatogrised nodes before…
4861667 
… sending metadata.

Update NodeCatalog Search filter to support single type search alongside name and category search
@singhutsav5502
Merge branch 'master' into filter-node-catalog
aa01f8e
@singhutsav5502
Take union of DocumentNodeTypes and registered node implementations, …
311a21c 
…Update missing categories and make sure to remove nodes with empty categories
@singhutsav5502
Add missing manual_composition for the Mask node
cc112ca
@singhutsav5502
Merge branch 'master' into manual_composition_mask_node
f6471d1
@singhutsav5502 singhutsav5502 deleted the manual_composition_mask_node branch March 20, 2025 04:02
@Keavon
Copy link
Member

Keavon commented Mar 20, 2025

What's the reason for closing this?

@singhutsav5502
Copy link
Contributor Author

singhutsav5502 commented Mar 20, 2025 •
edited
Loading

I accidentally checked this branch out from the branch responsible for #2423 instead of the master branch.
Merging this would have added code that already has an open PR.
The code change intended for this PR was just a single line for the Mask node definition, If you want i can open a new PR for that or club it along with #2423 .

@Keavon
Copy link
Member

Keavon commented Mar 20, 2025 •
edited
Loading

You can create a new branch with the same name with your 1-line change, push it to your fork, then reopen this PR. #2474 is the replacement, for the record.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singhutsav5502 @Keavon