-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tests for GRS transform cancellation #2467
Add tests for GRS transform cancellation #2467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution; the code and approach look good.
Please can you also add a testcase that doesn't cancel to ensure that we don't get the original transform in that case? This ensures that we are actually testing that the cancelling works.
…dd-grs-cancellation-tests
…2134/Graphite into add-grs-cancellation-tests
@0HyperCube @Keavon PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look good; thanks for the contribution.
Fix part of #2465
This PR adds tests to verify that cancellation works properly for the GRS (Grab, Rotate, Scale) transformation operations.
I implemented tests that:
Create a rectangle
Start a transform operation (G/R/S)
Move the cursor to change the transform
Cancel the operation
Verify the transform is unchanged after cancellation