Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GRS rotation (R) angle overlay label show values between -360° and 360° #2473

Merged
merged 7 commits into from
Apr 9, 2025

Conversation

4adex
Copy link
Contributor

@4adex 4adex commented Mar 19, 2025

From https://discord.com/channels/731730685944922173/881073965047636018/1352035208232308828


https://discord.com/channels/731730685944922173/881073965047636018/1349537593276239892
Needed a new transaction to be started before extending a path.

https://discord.com/channels/731730685944922173/881073965047636018/1345511109452632127
Should check that if both handles length are 0. or f64::MAX then tool selected is one of path tool or pen tool, not the select tool.

  • Broken out into a later PR and description moved from that Discord message link to an issue: #2534

@Keavon
Copy link
Member

Keavon commented Mar 20, 2025

#2439 completed the first part. Should your change be removed or does it help in some other way too, or do a better job?

@4adex
Copy link
Contributor Author

4adex commented Mar 20, 2025

Okay I wasn't aware of that, there was a confusion. There is already a start transaction before calling create_initial_point so things also work without the change I introduced.

@Keavon Keavon force-pushed the master branch 4 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
@Keavon
Copy link
Member

Keavon commented Apr 6, 2025

!build

Copy link

github-actions bot commented Apr 6, 2025

📦 Build Complete for be787c7
https://aa315d67.graphite.pages.dev

@Keavon Keavon marked this pull request as draft April 9, 2025 05:58
@Keavon Keavon changed the title Fixes issues from code todo list Fix sharp path points not supporting G/R/S when clicked, and their zero-length handles wrongly being box selected Apr 9, 2025
@Keavon Keavon changed the title Fix sharp path points not supporting G/R/S when clicked, and their zero-length handles wrongly being box selected Make GRS rotation (R) angle overlay label show values between -360° and 360° Apr 9, 2025
@Keavon Keavon marked this pull request as ready for review April 9, 2025 06:05
@Keavon Keavon enabled auto-merge (squash) April 9, 2025 06:06
@Keavon Keavon merged commit 8b0f16e into GraphiteEditor:master Apr 9, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants