-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for scaling objects to zero without any crash #2491
Add test for scaling objects to zero without any crash #2491
Conversation
@0HyperCube PTAL! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this. Scaling to zero should probably always work. However we've previously had problems whereby after scaling to zero and then transforming, a NaN value is used. This causes the SVG to be invalid. Please could you also test for applying another scale after setting the transform to zero? Thanks.
editor/src/messages/tool/transform_layer/transform_layer_message_handler.rs
Outdated
Show resolved
Hide resolved
@0HyperCube PTAL! |
editor/src/messages/tool/transform_layer/transform_layer_message_handler.rs
Outdated
Show resolved
Hide resolved
CLI failure is independent of changes - https://discord.com/channels/731730685944922173/731738914812854303/1358066874314916003 |
@0HyperCube will it be merge automatically after cli test will pass? |
aa7ff13
to
e11b57a
Compare
Fixes a part of #2465
This PR adds a test case that verifies the application correctly handles scaling objects to exactly zero. This edge case is important to test as it creates matrices with zero determinants, which could potentially cause numerical instability or crashes.