Fix a Pen tool regression where a new single-point layer doesn't get deleted but should#2566
Closed
c-mateo wants to merge 1 commit intoGraphiteEditor:masterfrom
Closed
Fix a Pen tool regression where a new single-point layer doesn't get deleted but should#2566c-mateo wants to merge 1 commit intoGraphiteEditor:masterfrom
c-mateo wants to merge 1 commit intoGraphiteEditor:masterfrom
Conversation
Member
|
@0SlowPoke0 can you please review this? |
Member
|
@c-mateo please clarify what this regression is, since we can't seem to reproduce it in https://dev.graphite.rs. |
Contributor
Author
|
As #2503 describes, a single anchor path can be created by:
And this is not desired. The bug is present in https://editor.graphite.rs/ |
Member
This is not a deployment of master. |
Contributor
Author
|
I used to hunt bugs there. So, false alarm? And what's deployed there? |
Member
|
Yes, always use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #2503 was reintroduced in #2452 by the line 1928 inpen_tool.rs. This PR fixes it but please check the improvements done in #2452 are still working fine.