Skip to content

Fix a Pen tool regression where a new single-point layer doesn't get deleted but should#2566

Closed
c-mateo wants to merge 1 commit intoGraphiteEditor:masterfrom
c-mateo:fix-2503-again
Closed

Fix a Pen tool regression where a new single-point layer doesn't get deleted but should#2566
c-mateo wants to merge 1 commit intoGraphiteEditor:masterfrom
c-mateo:fix-2503-again

Conversation

@c-mateo
Copy link
Contributor

@c-mateo c-mateo commented Apr 13, 2025

Issue #2503 was reintroduced in #2452 by the line 1928 in pen_tool.rs. This PR fixes it but please check the improvements done in #2452 are still working fine.

@c-mateo c-mateo changed the title Fix #2503 again Make pen tool create single anchor path again #2503 Apr 13, 2025
@Keavon
Copy link
Member

Keavon commented Apr 13, 2025

@0SlowPoke0 can you please review this?

@Keavon Keavon changed the title Make pen tool create single anchor path again #2503 Fix a Pen tool regression where a new single-point layer doesn't get deleted but should Apr 13, 2025
@Keavon
Copy link
Member

Keavon commented Apr 14, 2025

@c-mateo please clarify what this regression is, since we can't seem to reproduce it in https://dev.graphite.rs.

@Keavon Keavon marked this pull request as draft April 14, 2025 06:05
@c-mateo
Copy link
Contributor Author

c-mateo commented Apr 14, 2025

As #2503 describes, a single anchor path can be created by:

  • Selecting the pen tool
  • Mouse down
  • Mouse up
  • Switch to another tool (with a shortcut or the button)

And this is not desired. The bug is present in https://editor.graphite.rs/

@Keavon
Copy link
Member

Keavon commented Apr 14, 2025

The bug is present in https://editor.graphite.rs/

This is not a deployment of master.

@c-mateo
Copy link
Contributor Author

c-mateo commented Apr 14, 2025

I used to hunt bugs there. So, false alarm? And what's deployed there?

@Keavon
Copy link
Member

Keavon commented Apr 14, 2025

Yes, always use dev not editor (prod) for finding bugs. Prod deploys https://github.com/GraphiteEditor/Graphite/releases/tag/latest-stable and you can also always use the Help > About Graphite... menu to view the commit hash and look up that commit for any deploy you're ever running.

@Keavon Keavon closed this Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants