Skip to content

Fix Spline tool in-progress drawing being cleared on tool change #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LixiviaDev
Copy link

Spline Tool: Spline won't stay unless closed or (Esc or Enter) is pressed.

My changes:

  • Removed "::AbortTransaction" message, which completely cleared the new spline on "::abort".
  • Added "delete_preview()" function to delete the preview point that tracks the mouse.
  • Added "::EndTransaction" message to signal that we want to save the new spline as is.

Copy link

github-actions bot commented Jul 5, 2025

📦 Build Complete for 1c24ad0
https://713097c1.graphite.pages.dev

Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for this fix.

@Keavon Keavon changed the title Fix spline cleared on tool change Fix Spline being cleared on tool change Jul 5, 2025
@Keavon Keavon changed the title Fix Spline being cleared on tool change Fix Spline tool in-progress drawing being cleared on tool change Jul 5, 2025
@Keavon
Copy link
Member

Keavon commented Jul 5, 2025

This does not appear to solve the problem in the specific case of switching to the Select tool (with the V hotkey or clicking its icon). It does seem to work as expected when switching to the other tools that I've tested. Could you please take a look at solving it for that tool?

@Keavon Keavon marked this pull request as draft July 5, 2025 22:48
@LixiviaDev
Copy link
Author

I'm really busy these days, I'll take a look at it as soon as I can

@Keavon Keavon force-pushed the master branch 4 times, most recently from ec51271 to e025103 Compare July 10, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants