Implement character bonuses for combined features#2286
Conversation
KingRainbow44
left a comment
KingRainbow44
left a comment
There was a problem hiding this comment.
something like HashMap<Integer, Integer> itemToRegion should be a constant and declared as Map<Integer, Integer
Co-authored-by: Magix <27646710+KingRainbow44@users.noreply.github.com>
|
please resolve the requested changes, as well as making your code build |
|
closing due to stale PR, feel free to reopen if you wish to complete the requested changes! |
|
Can you reopen PR for me? Before that, I forgot about this PR because I hadn't played it in a while. :))) |
…sData not found in 4.0 resource), instead, load from CombineBonus.json in the data folder
|
CombineBonusExcelConfigData.json is no longer found in ExcelBinOutput of resource version 4.0 so I created CombineBonus.json in the data folder.
|
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| DataLoader.loadList("CombineBonus.json", CombineBonusData.class) | ||
| .forEach(entry -> combineBonusData.put(entry.getAvatarId(), entry)); | ||
| } catch (Exception ignored) { | ||
| Grasscutter.getLogger() |
There was a problem hiding this comment.
can we get a thing here to load the resource and copy it to the data dir? i dont expect people to copy the file when they see this warning
The file is still located in ExcelBinOutput, as long as it is still in the game it should still be in resources. |
3 participants
Description
Implement character bonuses for combined features. include 3 type bonuses with 11 characters.
Yae Miko
Lisa
Alhaitham
etc...
Issues fixed by this PR
Fix display of combine result multiple times with received item.
Type of changes
Checklist: