refactor: sizeOverride #57
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to preserve some of the functionality of the
sizepreset outlined in #56 -- specifically, this PR modifies the expectation ofsizebeing a way to set default values that can later be overriden, into an override itself:sizeOverrideJust like before, the following is true:
deploys a cluster with the same specs as this:
The difference is that now,
sizeOverrideinvalues.yamldoes not establish the defaults forreplicas(and eventually containerrequirements) for bothgrayloganddatanode. Instead it overrides the default values that live invalues.yamlalready, using a single setting instead of overriding each value individually.Even though it keeps the same convenience/QoL feature by simplifying the number of values to set in order to achieve a given recommended configuration, this refactoring prevents any individual value override: in order to increase the
graylog.replicasnumber, thesizeOverride=""value would need to be set first, which would unset the rest of the values likedatanode.replicasand so on, which means all those values then need to be set individually. As such, this PR might be introducing more of a demo feature.Until we sync on this issue, this PR will remain a draft.
Notes for Reviewers