fix(pgcopy): return typed error instead of panicking on extra columns from query:#435
Open
SAY-5 wants to merge 1 commit intoGreenmaskIO:mainfrom
Open
fix(pgcopy): return typed error instead of panicking on extra columns from query:#435SAY-5 wants to merge 1 commit intoGreenmaskIO:mainfrom
SAY-5 wants to merge 1 commit intoGreenmaskIO:mainfrom
Conversation
(*Row).Decode walked past the end of columnPos whenever the COPY stream contained more columns than the row was constructed for, crashing the dump goroutine with 'panic: runtime error: index out of range'. This fired in real workloads any time a transformation's 'query:' selected extra columns beyond the table's declared schema. Add an explicit length check on the fixed-size path: if a non-dynamic row sees idx >= len(columnPos), return a new ErrTupleSizeMismatch sentinel wrapped with the offending byte offset so the caller can surface a useful message. The dynamic path is unchanged. Add a regression test that constructs a 2-column row and feeds it 5 columns over the wire; on master the test panics, with the fix it returns ErrTupleSizeMismatch. Closes GreenmaskIO#432 Signed-off-by: SAY-5 <[email protected]>
Member
|
Hi! Thank you for your contribution. Could you provide a config that can reproduce a behavior related to this change? So I could test it in playground. |
Member
|
Have you tested the whole dump/restore cycle? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #432.
pgcopy.(*Row).Decodewalked past the end ofcolumnPoswhenever the COPY stream contained more columns than the row was constructed for. The dump goroutine then crashed with:This fired any time a transformation's
query:selected extra columns beyond the table's declared schema.Fix
Added an explicit length check on the fixed-size path: if a non-dynamic row sees
idx >= len(columnPos), return a newErrTupleSizeMismatchsentinel wrapped with the offending byte offset so the caller can surface a useful message. The dynamic path (UseDynamicSize) is unchanged.(*TransformationPipeline).Dumpalready wraps Decode errors witherror decoding copy line: %w, so the existing error path carries the message all the way out without any code changes at the call site.Tests
Added
TestDecode_extraColumnsTupleSizeMismatch: constructs a 2-column row, feeds it 5 columns over the wire, assertsErrTupleSizeMismatchis returned. On master this panics; with the fix it returns the typed error.Verification
Locally on macOS, go 1.26.2:
gofmt -s -l internal/db/postgres/pgcopy/: cleango vet ./internal/db/postgres/pgcopy/...: cleango test -race -count=1 ./internal/db/postgres/pgcopy/...: passCloses #432