Skip to content

fix(pgcopy): return clear error when row has more columns than tuple size #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(pgcopy): return clear error when row has more columns than tuple size #437

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/db/postgres/pgcopy/row.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ package pgcopy

import (
"errors"
"fmt"
"slices"

"github.com/greenmaskio/greenmask/pkg/toolkit"
Expand Down Expand Up @@ -100,6 +101,14 @@ func (r *Row) Decode(raw []byte) error {
r.appendNewEmptyBuffer()
}

// A static-tuple row that receives a stream with more columns
// than the table (e.g. a user `query:` that joins extra columns)
// would otherwise panic here with 'index out of range' inside
// the dump pipeline. Return a clear error instead.
if idx >= len(r.columnPos) {
return fmt.Errorf("pgcopy: row has more columns than the configured tuple size (%d); check that the transformation's `query:` does not select additional columns", r.tupleSize)
}

p := r.columnPos[idx]
p.start = colStartPos
p.end = colEndPos
Expand Down
Loading