-
Notifications
You must be signed in to change notification settings - Fork 60
feat: added session id filter for capture and raw capture #276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@nmcharlton I have added session id filter for both captures and raw captures. These changes are not yet tested. I'll test those and add unit tests as the next step |
@@ -71,7 +71,8 @@ router.get( | |||
query, | |||
Joi.object().keys({ | |||
grower_account_id: Joi.string().uuid(), | |||
organization_id: Joi.array(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a deliberate change? organization_id
should be an array to allow us to query multiple sub-organizations in one go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a mistake that I made when I add session_id field. I have pushed a fix for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@maxt0214 We're starting to add more detail to the validation. Can you please update to this ...
organization_id: Joi.array().items(Joi.string().uuid()), session_id: Joi.string().uuid(),
... and confirm your code is up-to-date, then resubmit for review. Thanks!
I followed the instruction in the readme to set up DB connection by essentially running:
When I direct frontend calls to my local server, it throws connection error with the database. Perhaps I have set up the db connection wrongly. What shall I do to fix this issue? |
@maxt0214 seems your database url env var doesn't work? |
No description provided.