Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

98 Create managed wallet #109

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Conversation

pranavkparti
Copy link
Collaborator

Description

The 'Create managed wallet' component is implemented in the Managed Wallets list page.

Issue(s) addressed

What kind of change(s) does this PR introduce?

  • Enhancement
  • Bug fix
  • Refactor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Issue

What is the current behavior?
The Managed Wallets page doesn't have functionality to create a managed wallet.

What is the new behavior?
image
image

Breaking change

Does this PR introduce a breaking change?
No.

Other useful information

None.

@pranavkparti pranavkparti requested a review from OlhaD January 15, 2024 06:59
@OlhaD
Copy link
Collaborator

OlhaD commented Jan 16, 2024

Hi @pranavkparti, thank you for the contribution!
Could you please remove the text "Please enter the name...." and move 'CreateManagedWallet.ts', '..test.ts', '..styles.ts' into a separate folder 'CreateManagedWallet'?

@OlhaD OlhaD merged commit 5bcd5d1 into Greenstand:v1 Jan 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Sub wallets
2 participants