122 customize wallet #460
Merged
122 customize wallet #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kpoke please review |
Kpoke
requested changes
Apr 18, 2024
| @@ -49,6 +49,14 @@ const walletPostSchema = Joi.object({ | |||
| about: Joi.string(), | |||
| }); | |||
|
|
|||
| const walletPatchSchema = Joi.object({ | |||
| id: Joi.string().uuid().required(), | |||
There was a problem hiding this comment.
id should not be here. The id should be gotten from the url /wallet/:id
There was a problem hiding this comment.
I removed it. Maybe I should better take it from the request (from the token) like in walletPost? It doesn't have id in the URL and I would expect Patch request to look similar to Post
| @@ -49,6 +49,14 @@ const walletPostSchema = Joi.object({ | |||
| about: Joi.string(), | |||
| }); | |||
|
|
|||
| const walletPatchSchema = Joi.object({ | |||
| id: Joi.string().uuid().required(), | |||
| name: Joi.string().required(), | |||
There was a problem hiding this comment.
Also, the name should not be updateable at this moment
|
🎉 This PR is included in version 1.38.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add an API to update wallet
Issue(s) addressed
Greenstand/treetracker-wallet-admin-client#122
What kind of change(s) does this PR introduce?