DFS stack-based recipe lookup implementation - #3986
Merged
Merged
Conversation
YoungOnionMC
approved these changes
Jan 5, 2026
TarLaboratories
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Swap our recursive recipe search implementation for a stack-based DFS one
Implementation Details
Blocked by #3981
Outcome
Additional Information
This fixes a bug with our previous implementation where if a recipe A,B,C is matched, but rejected, it won't look for any other recipes starting with A
Potential Compatibility Issues
Nothing that wasn't broken by the PR it depends on
We still need to do some testing on if we need the predicate at all now? probably not, and it will probably make it faster, since every predicate.test also checks the content for practically no reason now