[MUI] Conveyor and Simple Filter#4128
Merged
Merged
Conversation
Spicierspace153
changed the base branch from
yo/cover-works
to
yo/mui2/covers-p2
October 27, 2025 06:56
…ch-Modern into kath/mui/filters # Conflicts: # src/main/java/com/gregtechceu/gtceu/common/mui/GTGuiTextures.java
…ch-Modern into kath/mui/filters # Conflicts: # src/main/java/com/gregtechceu/gtceu/api/cover/IMuiCover.java # src/main/java/com/gregtechceu/gtceu/api/cover/filter/SimpleItemFilter.java # src/main/java/com/gregtechceu/gtceu/api/cover/filter/SmartItemFilter.java # src/main/java/com/gregtechceu/gtceu/api/item/ComponentItem.java # src/main/java/com/gregtechceu/gtceu/common/cover/ConveyorCover.java # src/main/java/com/gregtechceu/gtceu/common/cover/MachineControllerCover.java # src/main/java/com/gregtechceu/gtceu/common/cover/voiding/ItemVoidingCover.java
jurrejelle
requested changes
Feb 6, 2026
| handler.setStackInSlot(i, stack); | ||
| }).ignoreMaxStackSize(true).accessibility(true, false)))); | ||
|
|
||
| return new Dialog<>("simple_item_filter") |
Contributor
There was a problem hiding this comment.
This should have a hash of the current data of some sort, so you can open two dialogs of two different item filters at the same time
Comment on lines
+581
to
+622
| /* | ||
| * @Override | ||
| * public Widget createUIWidget() { | ||
| * final var group = new WidgetGroup(0, 0, 176, 137); | ||
| * group.addWidget(new LabelWidget(10, 5, Component.translatable(getUITitle(), GTValues.VN[tier]).getString())); | ||
| * | ||
| * group.addWidget(new IntInputWidget(10, 20, 156, 20, () -> this.transferRate, this::setTransferRate) | ||
| * .setMin(1).setMax(maxItemTransferRate)); | ||
| * | ||
| * final EnumSelectorWidget<DistributionMode> distributionSelector = new EnumSelectorWidget<>(146, 67, 20, 20, | ||
| * DistributionMode.values(), distributionMode, this::setDistributionMode); | ||
| * | ||
| * distributionSelector.setVisible(shouldRespectDistributionMode()); | ||
| * group.addWidget(distributionSelector); | ||
| * | ||
| * ioModeSwitch = new SwitchWidget(10, 45, 20, 20, | ||
| * (clickData, value) -> { | ||
| * setIo(value ? IO.IN : IO.OUT); | ||
| * distributionSelector.setVisible(shouldRespectDistributionMode()); | ||
| * ioModeSwitch.setHoverTooltips( | ||
| * LocalizationUtils.format("cover.conveyor.mode", LocalizationUtils.format(io.tooltip))); | ||
| * }) | ||
| * .setTexture( | ||
| * new GuiTextureGroup(GuiTextures.VANILLA_BUTTON, IO.OUT.icon), | ||
| * new GuiTextureGroup(GuiTextures.VANILLA_BUTTON, IO.IN.icon)) | ||
| * .setPressed(io == IO.IN) | ||
| * .setHoverTooltips( | ||
| * LocalizationUtils.format("cover.conveyor.mode", LocalizationUtils.format(io.tooltip))); | ||
| * group.addWidget(ioModeSwitch); | ||
| * | ||
| * group.addWidget(new EnumSelectorWidget<>(146, 107, 20, 20, | ||
| * ManualIOMode.VALUES, manualIOMode, this::setManualIOMode) | ||
| * .setHoverTooltips("cover.universal.manual_import_export.mode.description")); | ||
| * | ||
| * group.addWidget(filterHandler.createFilterSlotUI(125, 108)); | ||
| * group.addWidget(filterHandler.createFilterConfigUI(10, 72, 156, 60)); | ||
| * | ||
| * buildAdditionalUI(group); | ||
| * | ||
| * return group; | ||
| * } | ||
| */ |
Comment on lines
+46
to
+54
| // @Override | ||
| // public ModularUI createUI(HeldItemUIFactory.HeldItemHolder holder, Player entityPlayer) { | ||
| // var held = holder.getHeld(); | ||
| // return new ModularUI(176, 157, holder, entityPlayer) | ||
| // .background(GuiTextures.BACKGROUND) | ||
| // .widget(new LabelWidget(5, 5, held.getDescriptionId())) | ||
| // .widget(ItemFilter.loadFilter(held).openConfigurator((176 - 80) / 2, (60 - 55) / 2 + 15)) | ||
| // .widget(UITemplate.bindPlayerInventory(entityPlayer.getInventory(), GuiTextures.SLOT, 7, 75, true)); | ||
| // } |
jurrejelle
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fitler is done, needs further refinement but works functionally so just need to fix jank (like panel autoclosing / shape in e.g. conveyor), but we can already merge this into the cover PR after and finish those up