Skip to content

Fix manual mode for item/fluid filter covers and conveyors/pumps#4245

Merged
jurrejelle merged 4 commits into
GregTechCEu:1.20.1from
programmer3481:1.20.1-manualmodefix
Nov 29, 2025
Merged

Fix manual mode for item/fluid filter covers and conveyors/pumps#4245
jurrejelle merged 4 commits into
GregTechCEu:1.20.1from
programmer3481:1.20.1-manualmodefix

Conversation

@programmer3481

Copy link
Copy Markdown
Contributor

What

tries to fix many of manual io bugs
see: https://discord.com/channels/701354865217110096/1089296351906504835/1442285824074055731

Outcome

  • all cases of items being pushed/pulled through item filter/conveyor covers from external sources have been fixed for all manual io modes
  • this includes item voiding bug due to filter cover's extract method not handling simulate parameter correctly
  • attempt to fix auto output + manual io mode bugs, with limitations; for example, auto output + conveyor with filter doesn't respect manual io

Additional Information

many of these probably needs a bigger code refactor that i'm not knowledgable enough to do such as

  • conveyors inheriting filter cover behavior somehow, so handling for both's filters isn't duplicated and missing in places
    - MetaMachine.getItemCapFilter's io parameter should probably be changed, it doesn't really make sense with IO.BOTH/NONE, it only is used with IO.IN/OUT anyway
  • refactor other duplicate code probably, like getItemcCapFilter is used everywhere in similar ways, bunch of similar exportToNearby methods, etc

Potential Compatibility Issues / Implementation Details

should be no compat issues, tried to not modify current code structure as much as possible
although a bigger cleanup is probably needed later, see above

@programmer3481 programmer3481 requested a review from a team as a code owner November 28, 2025 09:25
@TarLaboratories TarLaboratories added type: bugfix General bug fixes Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Nov 29, 2025
@jurrejelle jurrejelle merged commit 3aad948 into GregTechCEu:1.20.1 Nov 29, 2025
6 checks passed
LeoDreamer2004 pushed a commit to LeoDreamer2004/GregTech-Modern that referenced this pull request Dec 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. type: bugfix General bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants