[MUI2] Battery Buffer#4281
Merged
Merged
Conversation
Merged
TarLaboratories
added
type: feature
jurrejelle
requested changes
Dec 6, 2025
jurrejelle
left a comment
jurrejelle
left a comment
Contributor
There was a problem hiding this comment.
Some questions, looks good for the rest! Maybe include a "before" screenshot so people can compare?
jurrejelle
reviewed
Dec 6, 2025
jurrejelle
left a comment
jurrejelle
left a comment
Contributor
There was a problem hiding this comment.
LGTM, would like a review from someone with more experience with MUI if possible :hapybapycat:
Contributor
|
Before pics: |
Contributor
Author
|
Added power button |
Contributor
|
IMO the 2nd screenshot with the 2x4 grid should be laid out as 4x2 instead |
Contributor
|
Agreed since that would follow the previous LDLib impl |
Contributor
java_5TFh4WG2PX.mp4LGTM |
jurrejelle
approved these changes
Dec 13, 2025
TarLaboratories
added this pull request to the merge queue
Dec 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Battery buffer UI
Implementation details
Someone will need to fix the dupe later (originating from slots not being properly synced in
GTMuiMachineUtilOutcome