Skip to content

[MUI2] Super/Quantum Tank#4282

Merged
jurrejelle merged 2 commits into
mui2-refactorfrom
jj/mui2/super-tanks
Dec 12, 2025
Merged

[MUI2] Super/Quantum Tank#4282
jurrejelle merged 2 commits into
mui2-refactorfrom
jj/mui2/super-tanks

Conversation

@jurrejelle

Copy link
Copy Markdown
Contributor

What

Super/quantum tank

Before:
image

After:

java_vy5vz5EBgK.mp4

Implementation Details

Only does QuantumTankMachine, not CreativeQuantumTankMachine

The tooltips don't work, but I believe this might be part of a bigger problem with MUI2 tooltips, see
image

@jurrejelle jurrejelle added the type: feature New feature or request bundled for a 0.X.0 Update label Dec 6, 2025
@jurrejelle
jurrejelle requested a review from a team as a code owner December 6, 2025 18:42
@jurrejelle jurrejelle added ignore changelog PR should not be added to the changelog. 1.20.1 Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. labels Dec 6, 2025
@jurrejelle jurrejelle mentioned this pull request Dec 6, 2025
@github-actions github-actions Bot added the Tests: Passed Game Tests have passed on this PR label Dec 6, 2025
@TarLaboratories

Copy link
Copy Markdown
Contributor

Tooltips don't work because they simply aren't in the LangHandler

@jurrejelle

Copy link
Copy Markdown
Contributor Author

Tooltips don't work because they simply aren't in the LangHandler

Yep, but we probably also wanna change stuff to not be modularui.[etc]

@TarLaboratories TarLaboratories left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except commented out code

@jurrejelle
jurrejelle added this pull request to the merge queue Dec 12, 2025
Merged via the queue into mui2-refactor with commit 3e92d4f Dec 12, 2025
4 checks passed
@jurrejelle
jurrejelle deleted the jj/mui2/super-tanks branch December 12, 2025 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.20.1 ignore changelog PR should not be added to the changelog. Release: Patch - 0.0.X Smaller changes that either are bug fixes or very minor tweaks. Tests: Passed Game Tests have passed on this PR type: feature New feature or request bundled for a 0.X.0 Update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants