Fix prospection data task#5076
Merged
Merged
Conversation
jurrejelle
added
ignore changelog
YoungOnionMC
approved these changes
Jul 11, 2026
screret
reviewed
Jul 11, 2026
|
|
||
| import com.mojang.brigadier.CommandDispatcher; | ||
|
|
||
| import static net.minecraft.commands.Commands.*; |
Contributor
There was a problem hiding this comment.
Dont remove this import, it's here for ease of use if/when client commands are added
Contributor
Author
There was a problem hiding this comment.
they can add it back when they do imo, rather that than danglign imports
|
|
||
| @Override | ||
| public void execute(NetworkEvent.Context context) { | ||
| UUID sender = Minecraft.getInstance().player.getUUID(); |
Contributor
There was a problem hiding this comment.
Is this fine to do on a dedicated server? I'm not sure.
Also check https://docs.minecraftforge.net/en/latest/networking/simpleimpl/#handling-packets
Contributor
Author
There was a problem hiding this comment.
Yeah, it works on a dedi server, we tested before merging
| register(SPacketSendWorldID.class, SPacketSendWorldID::new, NetworkDirection.PLAY_TO_CLIENT); | ||
| register(SPacketNotifyCapeChange.class, SPacketNotifyCapeChange::new, NetworkDirection.PLAY_TO_CLIENT); | ||
| register(SCPacketShareProspection.class, SCPacketShareProspection::new, null); | ||
| register(SPacketStartProspectionShare.class, SPacketStartProspectionShare::new, |
Contributor
There was a problem hiding this comment.
Move this above SCPacketProspectionShare's registration pls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#4919 made it so that the cache was called on the server. This doesn't work since the cache lives on the client. This adds a task to "Fetch" the data from the client and send it back to the server.
AI Usage
If you answered yes, please fill out the following information
Agent Used
Opus 4.8 high
Agent Usage Description
Asked it to fix the problem, I reviewed
Outcome
We can share the data
How Was This Tested
GTMCP dev run
Potential Compatibility Issues
This keeps the issue of "anyone can send any prospection data to anyone" but idt we have a way around that