Enable bloom safe mode by default#5078
Open
screret wants to merge 1 commit into
Open
Conversation
gustovafing
added
ignore changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Having thought about the matter a bit more, the features it adds (ex. specifying a whole model as having bloom with the JSON) don't outweigh the negatives (lots of possible incompatibility issues). Thus I believe that safe mode should be the default choice.
Implementation Details
changed a "false" to a "true" and modified the comment a bit to reflect the new default
AI Usage
Outcome
Bloom safe mode is enabled by default
How Was This Tested
Launched game with empty GT early config, checked the default value it wrote