Skip to content

Fix cover opening on pipes #5103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gustovafing merged 1 commit into from
Jul 14, 2026
Merged

Fix cover opening on pipes #5103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/com/gregtechceu/gtceu/api/block/PipeBlock.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ public InteractionResult use(BlockState state, Level level, BlockPos pos, Player
}

Set<GTToolType> types = ToolHelper.getToolTypes(itemStack);
if ((!types.isEmpty() && ToolHelper.canUse(itemStack))) {
if ((!types.isEmpty() && ToolHelper.canUse(itemStack)) || (types.isEmpty() && player.isShiftKeyDown())) {
var result = pipeBlockEntity.onToolClick(new ExtendedUseOnContext(player, hand, hit));
if (result.getSecond() == InteractionResult.CONSUME && player instanceof ServerPlayer serverPlayer) {
ToolHelper.playToolSound(result.getFirst(), serverPlayer);
Expand Down
3 changes: 3 additions & 0 deletions src/main/java/com/gregtechceu/gtceu/api/cover/CoverBehavior.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,9 @@ public boolean canConnectRedstone() {

public final Pair<@Nullable GTToolType, InteractionResult> onToolClick(ExtendedUseOnContext context) {
var toolType = context.getToolType();
if (toolType.isEmpty() && context.getPlayer().isShiftKeyDown()) {
return Pair.of(null, onScrewdriverClick(context));
}
if (toolType.contains(GTToolType.SCREWDRIVER)) {
return Pair.of(GTToolType.SCREWDRIVER, onScrewdriverClick(context));
} else if (toolType.contains(GTToolType.SOFT_MALLET)) {
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/gregtechceu/gtceu/common/cover/detector/MaintenanceDetectorCover.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public boolean canAttach() {
return false;
}

return super.canAttach() && coverHolder instanceof MaintenanceHatchPartMachine;
return super.canAttach() && coverHolder.getHolder() instanceof MaintenanceHatchPartMachine;
}

@Override
Expand Down
Loading