Fix warnings as of rust 1.73.0 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ironedde
changed the title
Ironedde
changed the title
nilfit
previously requested changes
Oct 21, 2023
added 2 commits
October 22, 2023 18:36
Fixed clippy recommendation regarding `filter_map`, see clippy lint `filter_map_bool_then` for details.
Resolver need to be set on workspace level. See rust-lang/cargo#10112
epontan
approved these changes
Oct 23, 2023
epontan
approved these changes
Oct 23, 2023
Ironedde
pushed a commit
to Ironedde/mcan-clone
that referenced
this pull request
Oct 24, 2023
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Merged
Ironedde
pushed a commit
to Ironedde/mcan-clone
that referenced
this pull request
Oct 24, 2023
- Added - Add `Can::aux::initialization_mode` (GrepitAB#41) - Changed - Fix some issues with watermark sizes for Rx FIFOs and Tx Event FIFO (GrepitAB#43) - Adhere to `filter_map_bool_then` clippy lint (GrepitAB#42)
Ironedde
added a commit
that referenced
this pull request
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All workspace members are already edition 2021 (implying resolver 2).
Setting it on workspace to silence warnings.
Fixed clippy recommendation regarding
filter_map, see clippy lintfilter_map_bool_thenfor details.Thank you!
Thank you for your contribution.
Please make sure that your submission includes the following:
Must
errorsorwarnings.cargo +stable fmtwas run.cargo +stable clippyyields nowarnings.CHANGELOG.mdin the proper section.newly added features and code.