feat: memtable seq range read #6950
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
docs-not-required
Signed-off-by: discord9 <[email protected]>
discord9
force-pushed
the
mem_seq_read
branch
from
f5b2269 to
315d738
Compare
Signed-off-by: discord9 <[email protected]>
discord9
requested review from
v0y4g3r,
evenyag and
waynexia
as code owners
Signed-off-by: discord9 <[email protected]>
evenyag
reviewed
Sep 24, 2025
Comment on lines
+26
to
+39
| From { | ||
| /// Exclusive lower bound | ||
| min: SequenceNumber, | ||
| }, | ||
| To { | ||
| /// Inclusive upper bound | ||
| max: SequenceNumber, | ||
| }, | ||
| Range { | ||
| /// Exclusive lower bound | ||
| min: SequenceNumber, | ||
| /// Inclusive upper bound | ||
| max: SequenceNumber, | ||
| }, |
There was a problem hiding this comment.
non-blocking: Maybe we can use Gt/LtEq? WDYT
Suggested change
| From { | |
| /// Exclusive lower bound | |
| min: SequenceNumber, | |
| }, | |
| To { | |
| /// Inclusive upper bound | |
| max: SequenceNumber, | |
| }, | |
| Range { | |
| /// Exclusive lower bound | |
| min: SequenceNumber, | |
| /// Inclusive upper bound | |
| max: SequenceNumber, | |
| }, | |
| Gt { | |
| /// Exclusive lower bound | |
| min: SequenceNumber, | |
| }, | |
| LtEq { | |
| /// Inclusive upper bound | |
| max: SequenceNumber, | |
| }, | |
| GtLtEq { | |
| /// Exclusive lower bound | |
| min: SequenceNumber, | |
| /// Inclusive upper bound | |
| max: SequenceNumber, | |
| }, |
Comment on lines
+62
to
+63
| /// If set, only the memtables that contain sequences greater than this value will be scanned | ||
| pub memtable_min_sequence: Option<SequenceNumber>, |
| /// Optional constraint on the sequence number of the rows to read. | ||
| /// If set, only rows with a sequence number lesser or equal to this value | ||
| /// will be returned. | ||
| pub sequence: Option<SequenceNumber>, |
There was a problem hiding this comment.
Do we need to rename this to max_sequence?
There was a problem hiding this comment.
Do we need to rename this to max_sequence?
still useful for refilling which might still need to limit the sequence range and such
There was a problem hiding this comment.
Will renaming this field break this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
What's changed and what's your intention?
add a sequence range to scan request for scanning memtable within given sequence range, useful for seq read for append only table's partial update query
PR Checklist
Please convert it to a draft if some of the following conditions are not met.