-
Notifications
You must be signed in to change notification settings - Fork 416
feat: converts batches in old format to the flat format in query time #6987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
evenyag
wants to merge
19
commits into
GreptimeTeam:main
Choose a base branch
from
evenyag:fix/convert-format
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
adds a method flat_sst_arrow_schema_column_num() to get the field num Signed-off-by: evenyag <[email protected]>
Adds two structs ParquetFlat and ParquetPrimaryKeyToFlat. ParquetPrimaryKeyToFlat delegates stats and projection to the PrimaryKeyReadFormat. Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
c836fbe
to
c3ea489
Compare
fengjiachun
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Signed-off-by: evenyag <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the GreptimeDB CLA.
Refer to a related PR or issue link (optional)
#6078
What's changed and what's your intention?
This PR converts batches to flat format when reading files with the old format.
num_columns
andfile_path
for FlatReadFormatParquetAdapter
to get stats and compute projection for the parquet file.ParquetAdapter
will delegate the operation toPrimaryKeyReadFormat
if the file has the old format.Other minor fixes:
compute_input_arrow_schema()
PR Checklist
Please convert it to a draft if some of the following conditions are not met.