Skip to content

refactor: rewrite some UDFs to DataFusion style (part 3) #6990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 23, 2025
Merged

refactor: rewrite some UDFs to DataFusion style (part 3) #6990

merged 4 commits into from
Sep 23, 2025

Conversation

MichaelScofield
Copy link
Collaborator

I hereby agree to the terms of the GreptimeDB CLA.

Refer to a related PR or issue link (optional)

What's changed and what's your intention?

as title

also tries to pass the FunctionContext through DataFusion

PR Checklist

Please convert it to a draft if some of the following conditions are not met.

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR requires documentation updates.
  • API changes are backward compatible.
  • Schema or data changes are backward compatible.

@github-actions github-actions bot added size/M docs-not-required This change does not impact docs. labels Sep 18, 2025
@MichaelScofield MichaelScofield force-pushed the refactor/rewrite-udf-to-datafusion-style branch from ff6a6cb to 6d79b9c Compare September 18, 2025 11:02
@github-actions github-actions bot added size/L and removed size/M labels Sep 18, 2025
@MichaelScofield MichaelScofield marked this pull request as ready for review September 18, 2025 11:50
@MichaelScofield MichaelScofield requested review from evenyag and a team as code owners September 18, 2025 11:50
sunng87
sunng87 reviewed Sep 18, 2025
View reviewed changes
sunng87
sunng87 reviewed Sep 18, 2025
View reviewed changes
Copilot
Copilot AI reviewed Sep 18, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@MichaelScofield MichaelScofield force-pushed the refactor/rewrite-udf-to-datafusion-style branch from 24d0b90 to 6f30b60 Compare September 19, 2025 01:47
@MichaelScofield
Copy link
Collaborator Author

@sunng87 PTAL

killme2008
killme2008 reviewed Sep 22, 2025
View reviewed changes
@MichaelScofield
Copy link
Collaborator Author

@killme2008 PTAL

@MichaelScofield MichaelScofield force-pushed the refactor/rewrite-udf-to-datafusion-style branch from 2ff881e to 69e98fe Compare September 23, 2025 07:21
@MichaelScofield MichaelScofield added this pull request to the merge queue Sep 23, 2025
Merged via the queue into main with commit 2712c5c Sep 23, 2025
42 checks passed
@MichaelScofield MichaelScofield deleted the refactor/rewrite-udf-to-datafusion-style branch September 23, 2025 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waynexia waynexia waynexia left review comments

Copilot code review Copilot Copilot left review comments

@killme2008 killme2008 killme2008 approved these changes

@sunng87 sunng87 sunng87 approved these changes

@evenyag evenyag Awaiting requested review from evenyag evenyag is a code owner

Assignees
No one assigned
Labels
docs-not-required This change does not impact docs. size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichaelScofield @killme2008 @sunng87 @waynexia