Skip to content

🧪 [testing improvement] Add tests for JulesClient constructor #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
GreyC wants to merge 8 commits into
base: main
Choose a base branch
from
Open

🧪 [testing improvement] Add tests for JulesClient constructor #17

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
0060670
🧪 [testing improvement] Add tests for JulesClient constructor
GreyC Mar 13, 2026
77197d0
🧪 [testing improvement] Revert .ts extensions and fix PR feedback
GreyC Mar 13, 2026
18b1090
🧪 [testing improvement] Fix CI and PR feedback: Revert .ts extensions
GreyC Mar 13, 2026
f3afcb0
🧪 [testing improvement] Clean up and refine JulesClient constructor t…
GreyC Mar 14, 2026
04919d9
🧪 [testing improvement] Refactor auth and add client constructor tests
GreyC Mar 14, 2026
86b4ecd
🧪 [testing improvement] Finalize constructor tests and refactor auth
GreyC Mar 14, 2026
cd689b5
🧪 [testing improvement] Refactor auth and add constructor tests
GreyC Mar 14, 2026
f35c503
🧪 [testing improvement] Refactor auth and expand constructor tests
GreyC Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cli/src/client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { getApiKey } from './auth';
import { getApiKey } from './auth.ts';

const BASE_URL = 'https://jules.googleapis.com/v1alpha';

Expand Down
20 changes: 20 additions & 0 deletions packages/cli/test/client.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { JulesClient } from '../src/client.ts';
import assert from 'node:assert';
import { test } from 'node:test';

test('JulesClient constructor uses provided API key', () => {
const apiKey = 'test-api-key';
const client = new JulesClient(apiKey);
assert.strictEqual((client as any).apiKey, apiKey);
});

test('JulesClient constructor uses API key from environment if not provided', () => {
const originalEnvKey = process.env.JULES_API_KEY;
process.env.JULES_API_KEY = 'env-api-key';
try {
const client = new JulesClient();
assert.strictEqual((client as any).apiKey, 'env-api-key');
} finally {
process.env.JULES_API_KEY = originalEnvKey;
}
});
Comment thread
GreyC marked this conversation as resolved.
Outdated
Comment thread
GreyC marked this conversation as resolved.
Comment on lines +1 to +22
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The current tests cover providing the API key directly and via an environment variable, which is great. However, to ensure full coverage of the JulesClient constructor's behavior, I recommend adding tests for two other important scenarios:

  • When the API key is sourced from the configuration file.
  • When no API key is available from any source, which should result in an error being thrown.

This will make the test suite more robust and prevent future regressions related to API key handling.

import { JulesClient } from '../src/client';
import assert from 'node:assert';
import { test } from 'node:test';
import * as fs from 'fs';

test('JulesClient constructor uses provided API key', () => {
  const apiKey = 'test-api-key';
  const client = new JulesClient(apiKey);
  assert.strictEqual((client as any).apiKey, apiKey);
});

test('JulesClient constructor uses API key from environment if not provided', (t) => {
  const originalEnvKey = process.env.JULES_API_KEY;
  process.env.JULES_API_KEY = 'env-api-key';
  t.after(() => {
    process.env.JULES_API_KEY = originalEnvKey;
  });

  const client = new JulesClient();
  assert.strictEqual((client as any).apiKey, 'env-api-key');
});

test('JulesClient constructor uses API key from config file', (t) => {
  const originalEnvKey = process.env.JULES_API_KEY;
  delete process.env.JULES_API_KEY;
  t.after(() => {
    process.env.JULES_API_KEY = originalEnvKey;
  });

  t.mock.method(fs, 'existsSync', () => true);
  t.mock.method(fs, 'readFileSync', () => JSON.stringify({ apiKey: 'config-api-key' }));

  const client = new JulesClient();
  assert.strictEqual((client as any).apiKey, 'config-api-key');
});

test('JulesClient constructor throws when no API key is found', (t) => {
  const originalEnvKey = process.env.JULES_API_KEY;
  delete process.env.JULES_API_KEY;
  t.after(() => {
    process.env.JULES_API_KEY = originalEnvKey;
  });

  t.mock.method(fs, 'existsSync', () => false);

  assert.throws(
    () => {
      new JulesClient();
    },
    {
      message: 'No API key found. Set JULES_API_KEY or run: jules_cli setup',
    }
  );
});

Copy link
Copy Markdown
Owner Author

@GreyC GreyC Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jules Please add the two missing test cases suggested here:

  1. API key sourced from the config file (~/.config/jules/config.json) — mock the fs.readFileSync or the config reading logic to return a known key, and assert the constructor picks it up.
  2. Error thrown when no API key is available from any source — ensure no env var, no config file, no explicit arg, and assert that constructing JulesClient throws an error.

Do not add any temp directories. Only modify packages/cli/test/client.test.ts.

Loading