Skip to content

Remove Deprecated Use of FetchContent_Populate #1825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fthaler wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove Deprecated Use of FetchContent_Populate #1825

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
196c702
Remove deprecated use of FetchContent_Populate
fthaler Feb 18, 2026
632ddff
Merge remote-tracking branch 'upstream/master' into fetchcontent-update
fthaler Feb 18, 2026
cc1b1df
Remove unneeded FetchoContent_GetProperties
fthaler Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions docs_src/manuals/introduction/introduction.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,10 +142,7 @@ lines to your CMake project
URL https://github.com/GridTools/gridtools/archive/<release_tag>.tar.gz
)
FetchContent_GetProperties(GridTools)
if(NOT GridTools_POPULATED)
FetchContent_Populate(GridTools)
add_subdirectory(${gridtools_SOURCE_DIR} ${gridtools_BINARY_DIR})
endif()
FetchContent_MakeAvailable(GridTools)

where *<release_tag>* is the git tag of the |GT| release, e.g. ``v2.0.0``.

Expand Down
7 changes: 1 addition & 6 deletions tests/regression/py_bindings/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,7 @@ FetchContent_Declare(
GIT_TAG v2.10.0
)

FetchContent_GetProperties(pybind11)
if(NOT pybind11_POPULATED)
FetchContent_Populate(pybind11)
set(PYTHON_EXECUTABLE ${Python_EXECUTABLE})
Copy link
Contributor Author

@fthaler fthaler Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t know why this line existed, is it needed for something I’ve overlooked?

add_subdirectory(${pybind11_SOURCE_DIR} ${pybind11_BINARY_DIR})
endif()
FetchContent_MakeAvailable(pybind11)

pybind11_add_module(py_implementation implementation.cpp)

Expand Down
Loading