ci: add nox utilities for conditional session execution instead of using github actions#1982
Merged
egparedes merged 74 commits intoGridTools:mainfrom May 8, 2025
Merged
Conversation
…n paths of changed files
…ed to the session venvs
egparedes
changed the title
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- .github/workflows/test-eve-fallback.yml: Language not supported
Comments suppressed due to low confidence (1)
noxfile_utils.py:170
- The return type annotation of _filter_names is incorrect; it returns a set of strings rather than a string. Change the return type from 'str' to 'set[str]'.
def _filter_names(names: list[str], include_patterns: list[str], exclude_patterns: list[str]) -> str:
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Magdalena <luzm@ethz.ch>
Co-authored-by: Magdalena <luzm@ethz.ch>
…T_AUTO_NUM_WORKERS
There was a problem hiding this comment.
Pull Request Overview
This PR integrates new nox utilities for conditional session execution and updates CI/CD workflows accordingly while removing redundant GitHub Actions workflows.
- Updated the nox dependency version and configuration in pyproject.toml.
- Added utility functions in noxfile_utils.py and refactored noxfile.py to leverage these functions.
- Updated documentation, development tasks, pre-commit hooks, and all CI workflow definitions to support the new execution pattern.
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Bumped nox dependency to version >=2025.02.09 |
| noxfile_utils.py | Introduced utilities and decorators for conditional nox session execution |
| noxfile.py | Refactored sessions to use noxfile_utils and updated sys.path handling |
| docs/development/tools/ci-infrastructure.md | Revised documentation to reflect new CI/CD process and workflow removal |
| dev-tasks.py | Improved version extraction logic by limiting split output |
| .pre-commit-config.yaml | Added a local hook for noxfile_utils functionality |
| .github/workflows/*.yml | Updated workflows to use the new script execution pattern and deep clone |
stubbiali
pushed a commit
to stubbiali/gt4py
that referenced
this pull request
Aug 19, 2025
…ing github actions (GridTools#1982) Add extra utilities so now `nox` sessions can: - read the supported python versions from the `.python-versions` file - skip sessions conditionally based on the changes from a specific target commit - run nox sessions using the PEP 723 noxfiles way supported since 2025.02.09 - use the standard `PYTEST_XDIST_AUTO_NUM_WORKERS` variable (used by `pytest-xdist`) instead of custom `NUM_PROCESSES` variable, to select the number of workers in a pytest session The not-longer needed "fallback" GitHub Actions workflows have been also removed and the development documentation updated to reflect these changes. Co-authored-by: Magdalena <luzm@ethz.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add extra utilities so now
noxsessions can:.python-versionsfilePYTEST_XDIST_AUTO_NUM_WORKERSvariable (used bypytest-xdist) instead of customNUM_PROCESSESvariable, to select the number of workers in a pytest sessionThe not-longer needed "fallback" GitHub Actions workflows have been also removed and the development documentation updated to reflect these changes.
Show a summary per file (GitHub Copilot)