-
Notifications
You must be signed in to change notification settings - Fork 55
feat[next-dace]: Less Verbose Warnings #2544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
philip-paul-mueller
merged 18 commits into
GridTools:main
from
philip-paul-mueller:disable_warnings_in_debug_mode
Mar 24, 2026
Merged
Changes from 17 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
383b5c2
All warnings in the optimizer are now conditioned on the debug state.
philip-paul-mueller f7734a5
Merge branch 'main' into disable_warnings_in_debug_mode
philip-paul-mueller ea1610d
Fixed a compatibility issue.
philip-paul-mueller 22902dc
Removed some comments.
philip-paul-mueller bbe84de
Added a small test.
philip-paul-mueller 4b2292e
Let's hope that this helps.
philip-paul-mueller cbb18fe
Setting the marker in `__init__.py` does not seem enough.
philip-paul-mueller 751c226
Small experiment.
philip-paul-mueller b1870f6
Revert "Small experiment."
philip-paul-mueller 5f4c2bf
Merge remote-tracking branch 'gt4py/main' into disable_warnings_in_de…
philip-paul-mueller 6ed3788
Started implementing Enrique's idea.
philip-paul-mueller c50576d
Modified the test.
philip-paul-mueller 092ac76
Blocked warnings from DaCe.
philip-paul-mueller 2fa7960
Addressed review comments.
philip-paul-mueller 2a75655
Renamed `SKIP_WARNINGS` to `SKIP_DACE_WARNINGS`.
philip-paul-mueller 030e98b
Merge remote-tracking branch 'gt4py/main' into disable_warnings_in_d…
philip-paul-mueller eff1707
Forgot to change something.
philip-paul-mueller 38c4808
Applied Edoardo's suggestion.
philip-paul-mueller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
...ts/program_processor_tests/runners_tests/dace_tests/transformation_tests/test_warnings.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # GT4Py - GridTools Framework | ||
| # | ||
| # Copyright (c) 2014-2024, ETH Zurich | ||
| # All rights reserved. | ||
| # | ||
| # Please, refer to the LICENSE file in the root directory. | ||
| # SPDX-License-Identifier: BSD-3-Clause | ||
|
|
||
| import pytest | ||
| import warnings | ||
|
|
||
| from gt4py.next import config as gtx_config | ||
|
|
||
|
|
||
| def test_if_warning_is_raised(): | ||
| assert not gtx_config.SKIP_DACE_WARNINGS or not __debug__, "Tests do not run in debug mode." | ||
|
|
||
| warn_msg = "This is a warning." | ||
| with pytest.warns(UserWarning, match=warn_msg): | ||
philip-paul-mueller marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| warnings.warn(warn_msg, UserWarning) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are also warnings in
workflowthat would still be active.If the new flag (which might be badly named) should have the meaning "I know what I am doing with DaCe do not bother me" then we should keep the current pattern, I would say.
I have nothing against the changes, I just would like to point that out.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have checked the warnings and they look like real warnings, that should not appear in ICON-blueline.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean, I would only skip the warnings in
dace.transformations.