Hw3 #12
Merged
Hw3 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsvgit
reviewed
Dec 26, 2024
Test/TestsHw3.fs
Outdated
| [<Fact>] | ||
| let MergeTest () = | ||
| let expected = List.sort [] | ||
| let mutable lst = MyList.fromList [] |
There was a problem hiding this comment.
А зачем ему быть изменяемым?
Test/TestsHw3.fs
Outdated
| [<Fact>] | ||
| let BubbleTest () = | ||
| let expected = List.sort [] | ||
| let mutable lst = MyList.fromList [] |
src/LibHw3/Library.fs
Outdated
| match list with | ||
| | Empty -> Empty | ||
| | Cons (pivot, tail) -> | ||
| let less = fromList (List.filter (fun x -> compare x pivot < 0) (toList tail)) |
There was a problem hiding this comment.
Конврттировать туда-обратно --- плохая затея. Много лишних телодвижений.
gsvgit
reviewed
Feb 27, 2025
src/LibHw3/Library.fs
Outdated
| match list with | ||
| | Empty -> Empty | ||
| | Cons (elem, tl) when func elem -> Cons (elem, filter func tl) | ||
| | Cons (elem, Empty) when func elem = false -> Empty |
There was a problem hiding this comment.
Реально надо писать прям = false? Просто логически выражением не обойтись?
gsvgit
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Новая ветка HW3. Исправил тип MyList и добавил новые тесты для него.