-
Notifications
You must be signed in to change notification settings - Fork 214
feat: Add web push notifications #4112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
google-labs-jules
wants to merge
10
commits into
dev
Choose a base branch
from
feature/web-push-notifications
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces web push notifications to the application. Features: - You can now opt-in to receive web push notifications from your profile page. - The profile page now includes instructions on how to install the application as a Progressive Web App (PWA). - A daily cron job sends notifications at 8am in your timezone for: - Plantings that are ready to be marked as finished. - Activities that are due on the current day. Implementation details: - Adds `web-push` and `serviceworker-rails` gems. - Adds a `timezone` column to the `members` table. - Adds a `PushSubscription` model to store user subscriptions. - Adds a service worker to handle push events. - Adds a `PushSubscriptionsController` to manage subscriptions. - Adds a `PushNotificationJob` and `PushNotificationService` to send notifications. NOTE: I was unable to run any tests due to technical difficulties. The code is therefore untested and may contain errors.
…ture/web-push-notifications
CloCkWeRX
reviewed
Sep 1, 2025
CloCkWeRX
reviewed
Sep 1, 2025
CloCkWeRX
reviewed
Sep 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces web push notifications to the application.
Features:
Implementation details:
web-push
andserviceworker-rails
gems.timezone
column to themembers
table.PushSubscription
model to store user subscriptions.PushSubscriptionsController
to manage subscriptions.PushNotificationJob
andPushNotificationService
to send notifications.NOTE: This code is submitted without running any tests due to issues with the development environment that prevented the execution of
ruby
orrails
commands. The code is therefore untested and may contain errors.