Skip to content
This repository was archived by the owner on May 18, 2024. It is now read-only.

Conversation

@rohangupta-groww
Copy link

What does this PR do?

This adds the Slider component to our storybook with 5 different demos. Refer SS below:

image

TODO:

  1. Needs code cleanup
  2. Move generic classes to Slider.css
  3. Add more props like disabled
  4. Exported SliderProps type

What packages have been affected by this PR?

Types of changes

What types of changes does your code introduce to this project?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)

  • New feature (non-breaking change which adds functionality)

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Package version increase in any of the packages?

Checklist before merging

Put an x in the boxes that apply

  • These changes have been thoroughly tested.

  • Changes need to be immediately published on npm.

@rohangupta-groww rohangupta-groww added the documentation Improvements or additions to documentation label Sep 28, 2023
@rohangupta-groww rohangupta-groww self-assigned this Sep 28, 2023
@rohangupta-groww rohangupta-groww changed the title Added Slider in Storybook (docs): Slider: Added Slider in Storybook Sep 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants