docs(14): the compact block — DSS SP pause fix, measured & gated#2
Merged
Conversation
New chapter on Patrick Domack's compact-block demux fix (hirparak/dss-codec#14): a DSS SP recording can encode a pause as a short 0xFF-padded block, which our decoder read as audio and desynced the rest of the file on. Validated against 90 days of real traffic (327 files; ~4 recordings/quarter affected), gated so only files with a genuine mid-stream compact block divert — everything else stays byte-identical — and shipped to the production binary. Also credit Patrick for the fix in CREDITS.md, and bring the docs index up to date (chapters 11–14 were missing; footer count fixed).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Chapter 14 plus the credit/index trail for Patrick Domack's DSS SP compact-block demux fix (upstream hirparak/dss-codec#14), validated against real production traffic and shipped.
Changes
docs/14-the-compact-block-pause.md— new chapter: the pull request, what a compact block is, the 90-day census, the surgical gate + byte-identical non-regression proof, and the honest coda on the repack pulse path we couldn't verify against the DLL.CREDITS.md— credit Patrick for the compact-block fix.docs/README.md— the chapter index was behind (11–14 missing); added them and fixed the footer count.Notes
0xFF-padded compact block divert to the block-aware batch demuxer; every other file keeps the streaming demuxer + chapter-13 re-sync, byte-identical (23/26 real SP files unchanged, 3 changed = the repaired ones, 25/25 QP unchanged).