Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PID to each CmdRun log #297

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Add PID to each CmdRun log #297

merged 1 commit into from
Feb 20, 2024

Conversation

kostyanf14
Copy link
Contributor

When multiple commands start in parallel it is difficult to understand what exactly fails.

akihikodaki
akihikodaki requested changes Feb 10, 2024
View reviewed changes
Copy link
Contributor

@akihikodaki akihikodaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement but I think printing PID is better as it can be used for kill, gdb, etc. during debugging and also saves code to generate and keep UUID.

@kostyanf14
Add PID to each CmdRun log
6c57336 
Signed-off-by: Kostiantyn Kostiuk <[email protected]>
@kostyanf14 kostyanf14 changed the title Add unique UUID to each CmdRun log Add PID to each CmdRun log Feb 19, 2024
@YanVugenfirer YanVugenfirer merged commit 26d1f9f into master Feb 20, 2024
5 checks passed
@YanVugenfirer YanVugenfirer deleted the cmd-uuid branch February 20, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YanVugenfirer YanVugenfirer YanVugenfirer approved these changes

@akihikodaki akihikodaki akihikodaki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kostyanf14 @YanVugenfirer @akihikodaki