Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding optional id into text insert #1022

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

KennyFukuya
Copy link

Description

Added param for id into /documents/text and /documents/texts

Related Issues

Changes Made

Checklist

  • [ X ] Changes tested locally
  • [ X ] Code reviewed
  • Documentation updated (if necessary)
  • Unit tests added (if applicable)

Additional Notes

[Add any additional notes or context for the reviewer(s).]

@danielaskdd
Copy link
Collaborator

Thank you for your contribution. Could you please clarify the purpose of requiring an ID for document insertion? Additionally, it would be helpful if you could provide several use cases for us to evaluate the implementation.

@danielaskdd danielaskdd self-assigned this Mar 11, 2025
@KennyFukuya
Copy link
Author

Thank you for your contribution. Could you please clarify the purpose of requiring an ID for document insertion? Additionally, it would be helpful if you could provide several use cases for us to evaluate the implementation.

The goal is to correctly map a document from another database by its doc uid. Currently the lightrag-server wasn't allowing that, but it is implemented into the package. My modification is just to allow the same method into the server.

Use case can be the insertion of any new text with its given id, if correctly its id on lightrag_doc_full must be the same as the one inserted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants