forked from PDAF/PDAF
-
Notifications
You must be signed in to change notification settings - Fork 4
Update PDAF version to 2.3 #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jjokella
wants to merge
86
commits into
tsmp-pdaf-patched
Choose a base branch
from
tsmp-pdaf-patched-v2.3
base: tsmp-pdaf-patched
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…This circumvents a bug in the LAPACK implementation of OpenBLAS <0.3.27)
…oes now suppose MPI-paralleliza tion. There is also one variant in which the MPI-specification is given as arguments in the call. Th e old routine is still available as PDAF_diag_CRPS_nompi. The new routines use SANGOMA_quicksort for more efficient sorting.
… dim_obs_p=0 when OMI is used. Now the number of calls is consistent with domains having dim_obs_p>0. This allows for global MPI operations in the observation operator
…clude file (necessary as on the Cray always 'ftn' is used, but might refer to ifort, cray-ftn, or gfortran)
…ices. In this case, the routine profRinvA_l is specified by the user. Thus, the multiplicaation with any form of R and be implemeented.
For inputs longer than 100 characters, only the first 100 characters are used as input, which may lead to unwanted behavior (f.e. when the input string is a path). This check aborts the execution, whenever the input string was longer than 100 characters.
For paths, the `READ` function supplied with the default format specifier `*` reads the input only up to the first appearance of the character `/`.
Error message: ``` 221 | WRITE (*,'(2x, a, x, a)') "called handle=", TRIM(string) | 1 Error: GNU Extension: X descriptor requires leading space count at (1) ```
…ore parser_mpi because the new check for the string lengths uses abort_parallel
…I observation localization weights into a new subroutine
… can be easily used from other routines
…AFlocal. Adapt src/Makefile and include full set of PDAFlocal and PDAFlocalomi routines in /Makefile
…ocal_set_increment_weights, PDAFlocal_clear_increment_weights from PDAFlocal module to make the easier usable. Also revise all tutorials and templates for using PDAFlocal and removing g2l_state_pdaf and l2g_state_pdaf.
…es that the computed value is not negative
…ate are only shown if PDAFlocal is not used
…f OMI-internal variables in user-supplied variants of PDAFomi_init_dim_obs_l
…s_l.F90. This replaces the previsou PDAFomi_init_dim_obs_l, which is still present as PDAFomi_init_dim_obs_l_old. The optimization yields better performance - for isotropic between 6-10x.
…. Now all allocations can be done in OMI-provided routines. Also storing the local index, distance and radii can be done in an OMI-provided routine. However, using this routine slowsdown the executation, in particular on the NEC.
…ep an example of using g2l_state_pdaf and l2g_state_pdaf
…since in this routine the pointer is set
needs to change for Intel/Gnu compilers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.