Part dependent processes #1
Conversation
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
|
|
||
| # Validate carrier specs | ||
|
|
||
| for obj in self._objects.values(): |
There was a problem hiding this comment.
this 2nd for loop is technically redundant. The if clause would also work in the for loop above, wouldnt it?
There was a problem hiding this comment.
I first need to collect all objects and pack them into self._objects first in order to validate the spec (which checks if a given process exists). So no, I think we need two for-loops here.
lineflow/simulation/stations.py
Outdated
| Args: | ||
| name (str): Name of the Cell | ||
| part_specs (list): List of dictionaries. Each dict contain specification about a part that | ||
| carrier_specs (list): List of dictionaries. Each dict contain specification about a carrier that |
There was a problem hiding this comment.
"A carrier that is assembled on the carrier"? This was confusing me.
|
Using dicts makes all this really hard to follow as a newbie. If these carrier_specs prove to be successful, it could be better to hold these in some kind of factory or at least some dataclasses which are given to the source/ to the magazine instead of |
Co-authored-by: Andreas Fritz <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
…art-dependent-processes
A first draft for adding part dependent processings induced by a
carrier_spec.