14 zoom in/out and move the camera #20
Conversation
Signed-off-by: Tobias Windisch <[email protected]>
Signed-off-by: Tobias Windisch <[email protected]>
windisch
left a comment
windisch
left a comment
There was a problem hiding this comment.
Very nice! I just have some comments we could also discuss synchronically for future refactorings.
| o.register(self.env) | ||
|
|
||
| def _draw(self, screen, actions=None): | ||
| def _draw(self, actions=None): |
There was a problem hiding this comment.
I moved more stuff into the Viewpoint class. Maybe - after the refactoring - all pygame specific things can happen inside Viewpoint?
There was a problem hiding this comment.
I wouldn't put everything in the Viewpoint class. But the visualization.py is supposed to contain every pygame specific thing in the future.
| if pygame.key.get_pressed()[pygame.K_RIGHT]: | ||
| self._view.x -= 10 | ||
|
|
||
| for event in pygame.event.get(): |
There was a problem hiding this comment.
@HSMarieK: I moved that piece to here as well - I think we could collect all sorts of user input here - what do you think?
| self.paper = pygame.Surface(size) | ||
|
|
||
|
|
||
| self.screen = pygame.display.set_mode((1280, 720)) |
There was a problem hiding this comment.
I made the screen an instance variable of the viewpoint. That way, a lot of things happen inside the viewpoint solely.
Signed-off-by: Tobias Windisch <[email protected]>
HSMarieK
left a comment
HSMarieK
left a comment
There was a problem hiding this comment.
The changes look good so far.
Signed-off-by: Tobias Windisch <[email protected]>
windisch
left a comment
windisch
left a comment
There was a problem hiding this comment.
Very nice! I added a tiny beautification and will merge this now - thanks a lot!
Added zoom in visualisation via +/- on the keyboard.
Added camera movement via arrow keys.
Added option to set initial zoom on "line.run()".