add Problem "linkedAfter" by MMachmerth · Pull Request #61 · HSDDigitalLabor/problems

MMachmerth · 2025-12-19T16:26:06Z

No description provided.

hsd-problem-testing · 2025-12-19T16:26:52Z

Problem	Solution	Type	Status	Message
binary	invalid_1	invalid	✅
binary	invalid_2	invalid	✅
binary	valid_1	valid	✅
binary	valid_2	valid	✅
bogo	invalid_1	invalid	✅
bogo	invalid_2	invalid	✅
bogo	invalid_3	invalid	✅
bogo	valid_1	valid	✅
bubble	invalid_1	invalid	✅
bubble	invalid_2	invalid	✅
bubble	invalid_3	invalid	✅
bubble	valid_1	valid	✅
divide-integers	alt_1	valid	✅
divide-integers	alt_2	valid	✅
divide-integers	invalid_1	invalid	✅
divide-integers	invalid_2	invalid	✅
divide-integers	invalid_3	invalid	✅
einsen	valid_1	valid	✅
einstein	alt_1	valid	✅
emojize	alt_1	valid	✅
emojize	alt_2	valid	✅
emojize	invalid_1	invalid	✅
extensions	alt_1	valid	✅
extensions	alt_2	valid	✅
faces	alt_1	valid	✅
hackers	valid_1	valid	✅
hello	alt_1	valid	✅
iban	valid_1	valid	✅
insert	invalid_1	invalid	✅
insert	valid_1	valid	✅
interpreter	valid_1	valid	✅
intervals	invalid_1	invalid	✅
intervals	valid_1	valid	✅
linear	valid_1	valid	✅
linear	valid_2	valid	✅
luhn	valid_1	valid	✅
merge	invalid_1	invalid	✅
merge	invalid_2	invalid	✅
merge	invalid_3	invalid	✅
merge	invalid_4	invalid	✅
merge	valid_1	valid	✅
merge	valid_2	valid	✅
merge	valid_3	valid	✅
merge	valid_4	valid	✅
nadel	alt_1	valid	✅
neuner			⚠️	Reason No tests found
palindrom	invalid_1	invalid	✅
palindrom	valid_1	valid	✅
playback	alt_1	valid	✅
rotate	invalid_1	invalid	✅
rotate	valid_1	valid	✅
rotate	valid_2	valid	✅
rotate	valid_3	valid	✅
rotate	valid_4	valid	✅
run_back	invalid_1	invalid	✅
run_back	invalid_2	invalid	✅
run_back	invalid_3	invalid	✅
run_back	valid_1	valid	✅
strings	alt_1	valid	✅
stufen	valid_1	valid	✅
stufen	valid_2	valid	✅
sudoku1	valid_1	valid	✅
sudoku1	valid_2	valid	✅
sudoku1	valid_3	valid	✅
sudoku2	valid_1	valid	✅
tip	alt_1	valid	✅
willkommen	alt_1	valid	✅
zahlenjagd	alt_1	valid	✅
zeilen	invalid_1	invalid	✅
zeilen	invalid_2	invalid	✅
zeilen	valid_1	valid	✅
zeilen	valid_2	valid	✅

Problem Summary: 72 total

✅ Passed: 71
🔴 Failed: 0
⚠️ Warnings: 1

Copilot

Pull request overview

This PR adds a new programming problem called "linkedAfter" that teaches students about linked list operations in Python. The problem requires students to implement an insertAfterNode method that inserts a new node after a specified node in a linked list.

Key changes include:

HTML documentation and instructions in German for students
Automated test suite using check50 to validate student solutions
Configuration files for submission and testing workflows

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 14 comments.

Show a summary per file

File	Description
linkedAfter/html/template.html	Template for problem instructions with code examples and testing guidance
linkedAfter/html/linkedAfter.html	Rendered HTML version of the problem instructions
linkedAfter/html/params.json	Configuration parameters for the problem (IDs, paths, filenames)
linkedAfter/checks/main.py	Automated test suite that validates the insertAfterNode implementation
linkedAfter/.cs50.yml	Configuration file for check50 and submit50 tools

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-19T16:28:38Z

+  In dieser Übung werden Sie die Datenstruktur <strong>Verkettete Liste (Linked List)</strong> erweitern.
+  Gegeben sind bereits die Klassen <code>ListNode</code> und <code>LinkedList</code>, sowie einige
+  Hilfsmethoden zur Erzeugung einer verkettenten List aus eine Python Liste <code>FromPythonlist(inputList)</code>
+  und der Methode zur Ausgabe einer verkettetenListe <code>printList()</code>. Eine weitere Methode ist 


Spelling error: "verkettetenListe" should be "verketteten Liste". Missing space between "verketteten" and "Liste".

Suggested change

und der Methode zur Ausgabe einer verkettetenListe <code>printList()</code>. Eine weitere Methode ist

und der Methode zur Ausgabe einer verketteten Liste <code>printList()</code>. Eine weitere Methode ist

Copilot · 2025-12-19T16:28:38Z

+  Gegeben sind bereits die Klassen <code>ListNode</code> und <code>LinkedList</code>, sowie einige
+  Hilfsmethoden zur Erzeugung einer verkettenten List aus eine Python Liste <code>FromPythonlist(inputList)</code>
+  und der Methode zur Ausgabe einer verkettetenListe <code>printList()</code>. Eine weitere Methode ist 
+  <code>searchValue(value)</code> mit deren Hilfe Sie eine ListenElement mit einem bestimmten Wert 


Spelling error: "ListenElement" should be "Listenelement". In German compound nouns, the second part should be lowercase when forming a compound (unless it's a proper noun).

Suggested change

<code>searchValue(value)</code> mit deren Hilfe Sie eine ListenElement mit einem bestimmten Wert

<code>searchValue(value)</code> mit deren Hilfe Sie ein Listenelement mit einem bestimmten Wert

Copilot · 2025-12-19T16:28:39Z

+<p>
+  Implementieren Sie die Funktion <code>insertAfterNode</code> in Python. 
+  Die Funktion bekommt das Element <code>prevNode</code> und das neue Element <code>newNode</code>
+  übergeben und soll das neuen Element in die Liste einfügen. Ist <code>prevNode</code> None,


Grammar error: "das neuen Element" should be "das neue Element". The adjective "neuen" should be "neue" when used with the neuter article "das" in accusative case.

Suggested change

übergeben und soll das neuen Element in die Liste einfügen. Ist <code>prevNode</code> None,

übergeben und soll das neue Element in die Liste einfügen. Ist <code>prevNode</code> None,

Copilot · 2025-12-19T16:28:39Z

+<p>
+  In dieser Übung werden Sie die Datenstruktur <strong>Verkettete Liste (Linked List)</strong> erweitern.
+  Gegeben sind bereits die Klassen <code>ListNode</code> und <code>LinkedList</code>, sowie einige
+  Hilfsmethoden zur Erzeugung einer verkettenten List aus eine Python Liste <code>FromPythonlist(inputList)</code>


Spelling error: "verkettenten List" should be "verketteten Liste". The word "verkettenten" is misspelled (should be "verketteten") and "List" should be "Liste" (feminine noun in German requires the feminine article form).

Suggested change

Hilfsmethoden zur Erzeugung einer verkettenten List aus eine Python Liste <code>FromPythonlist(inputList)</code>

Hilfsmethoden zur Erzeugung einer verketteten Liste aus einer Python Liste <code>FromPythonlist(inputList)</code>

Copilot · 2025-12-19T16:28:39Z

+  In dieser Übung werden Sie die Datenstruktur <strong>Verkettete Liste (Linked List)</strong> erweitern.
+  Gegeben sind bereits die Klassen <code>ListNode</code> und <code>LinkedList</code>, sowie einige
+  Hilfsmethoden zur Erzeugung einer verkettenten List aus eine Python Liste <code>FromPythonlist(inputList)</code>
+  und der Methode zur Ausgabe einer verkettetenListe <code>printList()</code>. Eine weitere Methode ist 


Spelling error: "verkettetenListe" should be "verketteten Liste". Missing space between "verketteten" and "Liste".

Suggested change

und der Methode zur Ausgabe einer verkettetenListe <code>printList()</code>. Eine weitere Methode ist

und der Methode zur Ausgabe einer verketteten Liste <code>printList()</code>. Eine weitere Methode ist

Copilot · 2025-12-19T16:28:40Z

+
+  print("Liste nachher:")
+  ll.printList()
+  # Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None


The expected output comment is incorrect. Given the list construction method using insertAfterHead (which reverses the order), the list starts as [4, 8, 2, 1]. After inserting 3 after 8, it should be [4, 8, 3, 2, 1], not [1, 2, 8, 3, 4]. This comment could mislead students about the expected behavior.

Suggested change

# Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None

# Erwartete Ausgabe: 4 -> 8 -> 3 -> 2 -> 1 -> None

Copilot · 2025-12-19T16:28:41Z

+  Gegeben sind bereits die Klassen <code>ListNode</code> und <code>LinkedList</code>, sowie einige
+  Hilfsmethoden zur Erzeugung einer verkettenten List aus eine Python Liste <code>FromPythonlist(inputList)</code>
+  und der Methode zur Ausgabe einer verkettetenListe <code>printList()</code>. Eine weitere Methode ist 
+  <code>searchValue(value)</code> mit deren Hilfe Sie eine ListenElement mit einem bestimmten Wert 


Spelling error: "ListenElement" should be "Listenelement". In German compound nouns, the second part should be lowercase when forming a compound (unless it's a proper noun).

Suggested change

<code>searchValue(value)</code> mit deren Hilfe Sie eine ListenElement mit einem bestimmten Wert

<code>searchValue(value)</code> mit deren Hilfe Sie eine Listenelement mit einem bestimmten Wert

Copilot · 2025-12-19T16:28:41Z

+<p>
+  Implementieren Sie die Funktion <code>insertAfterNode</code> in Python. 
+  Die Funktion bekommt das Element <code>prevNode</code> und das neue Element <code>newNode</code>
+  übergeben und soll das neuen Element in die Liste einfügen. Ist <code>prevNode</code> None,


Grammar error: "das neuen Element" should be "das neue Element". The adjective "neuen" should be "neue" when used with the neuter article "das" in accusative case.

Suggested change

übergeben und soll das neuen Element in die Liste einfügen. Ist <code>prevNode</code> None,

übergeben und soll das neue Element in die Liste einfügen. Ist <code>prevNode</code> None,

Copilot · 2025-12-19T16:28:41Z

+
+  print("Liste nachher:")
+  ll.printList()
+  # Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None


The expected output comment is incorrect. Given the list construction method using insertAfterHead (which reverses the order), the list starts as [4, 8, 2, 1]. After inserting 3 after 8, it should be [4, 8, 3, 2, 1], not [1, 2, 8, 3, 4]. This comment could mislead students about the expected behavior.

Suggested change

# Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None

# Erwartete Ausgabe: 4 -> 8 -> 3 -> 2 -> 1 -> None

Copilot · 2025-12-19T16:28:41Z

+        raise check50.Failure(msg)
+
+    if not hasattr(module.LinkedList(), "insertAfterNode"):
+        msg = "Method `insertAfterNode` not found Class `LinkedList`"


Grammar error in error message: "not found Class" should be "not found in Class". Missing the preposition "in" between "found" and "Class".

Suggested change

msg = "Method `insertAfterNode` not found Class `LinkedList`"

msg = "Method `insertAfterNode` not found in Class `LinkedList`"

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-19T18:10:14Z

+        threw = True
+
+    if not threw:
+        msg = "insertAfterNode should raise an error when prevNode is None (not found)"


The error message is unclear and uses an unexpected format. The message says "insertAfterNode should raise an error when prevNode is None (not found)" but should be more specific about what type of error is expected. The task description specifies that a ValueError should be raised, so the message should explicitly mention ValueError to help students understand the requirement.

Suggested change

msg = "insertAfterNode should raise an error when prevNode is None (not found)"

msg = "insertAfterNode should raise ValueError when prevNode is None (not found)"

Copilot · 2025-12-19T18:10:14Z

+
+  print("Liste nachher:")
+  ll.printList()
+  # Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None


The expected output in the documentation is incorrect. The comment states "Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None", but based on the FromPythonlist implementation which uses insertAfterHead, the list is actually built in reverse order. For inputList = [1, 2, 8, 4], the resulting list will be 4 -> 8 -> 2 -> 1, so after inserting 3 after 8, the expected output should be "4 -> 8 -> 3 -> 2 -> 1 -> None", not "1 -> 2 -> 8 -> 3 -> 4 -> None".

Suggested change

# Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None

# Erwartete Ausgabe: 4 -> 8 -> 3 -> 2 -> 1 -> None

Copilot · 2025-12-19T18:10:15Z

+
+  print("Liste nachher:")
+  ll.printList()
+  # Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None


The expected output in the documentation is incorrect. The comment states "Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None", but based on the FromPythonlist implementation which uses insertAfterHead, the list is actually built in reverse order. For inputList = [1, 2, 8, 4], the resulting list will be 4 -> 8 -> 2 -> 1, so after inserting 3 after 8, the expected output should be "4 -> 8 -> 3 -> 2 -> 1 -> None", not "1 -> 2 -> 8 -> 3 -> 4 -> None".

Suggested change

# Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None

# Erwartete Ausgabe: 4 -> 8 -> 3 -> 2 -> 1 -> None

Copilot

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-19T18:26:11Z

+        threw = True
+
+    if not threw:
+        msg = "insertAfterNode should raise an ValueError when prevNode is None"


Error message typo: "insertAfterNode should raise an ValueError" should be "insertAfterNode should raise a ValueError". The article before "ValueError" should be "a" not "an" since ValueError starts with a consonant sound.

Suggested change

msg = "insertAfterNode should raise an ValueError when prevNode is None"

msg = "insertAfterNode should raise a ValueError when prevNode is None"

Copilot · 2025-12-19T18:26:12Z

+@check50.check(has_classes_and_method)
+def test_insert_after_none_prevnode():
+    """insertAfterNode with prevNode=None:
+    We expect an exception (ValueError) rather than silently doing nothing."""


Documentation inconsistency: The multi-line string states "We expect an exception (ValueError)" but doesn't specify which exception type using proper formatting. Consider using backticks around ValueError for consistency with code documentation standards.

Suggested change

We expect an exception (ValueError) rather than silently doing nothing."""

We expect an exception (`ValueError`) rather than silently doing nothing."""

Copilot

Pull request overview

Copilot reviewed 32 out of 40 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 32 out of 40 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-22T11:27:02Z

+            newNode = ListNode(value=val)
+            self.insertAfterHead(newNode)
+
+    def searchValue(self, value: int) -> ListNode:


The return type annotation for searchValue is incorrect. The method signature shows it returns ListNode but should return ListNode | None to match the actual implementation in other files and handle cases where the value is not found.

Suggested change

def searchValue(self, value: int) -> ListNode:

def searchValue(self, value: int) -> ListNode | None:

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

MMachmerth requested a review from Copilot December 19, 2025 16:26

Copilot started reviewing on behalf of MMachmerth December 19, 2025 16:26 View session

Copilot AI reviewed Dec 19, 2025

View reviewed changes

MMachmerth force-pushed the LinkedLists branch 2 times, most recently from 7986d08 to 7538ca3 Compare December 19, 2025 18:05

MMachmerth requested a review from Copilot December 19, 2025 18:08

Copilot started reviewing on behalf of MMachmerth December 19, 2025 18:08 View session

Copilot AI reviewed Dec 19, 2025

View reviewed changes

add Problem "linkedAfter"

6fcb23f

MMachmerth force-pushed the LinkedLists branch from 7538ca3 to 6fcb23f Compare December 19, 2025 18:13

MMachmerth requested a review from Copilot December 19, 2025 18:24

Copilot started reviewing on behalf of MMachmerth December 19, 2025 18:24 View session

Copilot AI reviewed Dec 19, 2025

View reviewed changes

MMachmerth added 7 commits December 22, 2025 11:03

add linkedInsert

aea32c1

add linkedFind

fb98a5c

add linkedRemove

3ff0095

update LinkedAfter

3277d1b

add linkedStack

236fa33

add linkedMerge

bb01459

update linkedRemove

bade0eb

MMachmerth requested a review from Copilot December 22, 2025 11:16

Copilot started reviewing on behalf of MMachmerth December 22, 2025 11:16 View session

Copilot AI reviewed Dec 22, 2025

View reviewed changes

Comment thread linkedMerge/html/params.json Outdated

Comment thread linkedMerge/html/linkedMerge.html Outdated

MMachmerth and others added 4 commits December 22, 2025 12:17

format with Ruff

e1706f4

Update linkedMerge/html/linkedMerge.html

7e1c5a6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update linkedMerge/html/params.json

d652a21

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

format with Ruff

83c18b4

MMachmerth requested a review from Copilot December 22, 2025 11:24

Copilot started reviewing on behalf of MMachmerth December 22, 2025 11:25 View session

Copilot AI reviewed Dec 22, 2025

View reviewed changes

MMachmerth and others added 3 commits December 22, 2025 12:27

Update linkedAfter/html/template.html

0ba9f90

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

update LinkedAfter html

7e2612e

Merge remote-tracking branch 'origin/LinkedLists' into LinkedLists

e4adf45

MMachmerth closed this Dec 22, 2025

	und der Methode zur Ausgabe einer verkettetenListe <code>printList()</code>. Eine weitere Methode ist
	und der Methode zur Ausgabe einer verketteten Liste <code>printList()</code>. Eine weitere Methode ist

	<code>searchValue(value)</code> mit deren Hilfe Sie eine ListenElement mit einem bestimmten Wert
	<code>searchValue(value)</code> mit deren Hilfe Sie ein Listenelement mit einem bestimmten Wert

	übergeben und soll das neuen Element in die Liste einfügen. Ist <code>prevNode</code> None,
	übergeben und soll das neue Element in die Liste einfügen. Ist <code>prevNode</code> None,

	Hilfsmethoden zur Erzeugung einer verkettenten List aus eine Python Liste <code>FromPythonlist(inputList)</code>
	Hilfsmethoden zur Erzeugung einer verketteten Liste aus einer Python Liste <code>FromPythonlist(inputList)</code>

	# Erwartete Ausgabe: 1 -> 2 -> 8 -> 3 -> 4 -> None
	# Erwartete Ausgabe: 4 -> 8 -> 3 -> 2 -> 1 -> None

	msg = "Method `insertAfterNode` not found Class `LinkedList`"
	msg = "Method `insertAfterNode` not found in Class `LinkedList`"

	msg = "insertAfterNode should raise an error when prevNode is None (not found)"
	msg = "insertAfterNode should raise ValueError when prevNode is None (not found)"

	msg = "insertAfterNode should raise an ValueError when prevNode is None"
	msg = "insertAfterNode should raise a ValueError when prevNode is None"

	We expect an exception (ValueError) rather than silently doing nothing."""
	We expect an exception (`ValueError`) rather than silently doing nothing."""

	def searchValue(self, value: int) -> ListNode:
	def searchValue(self, value: int) -> ListNode \| None:

Conversation

MMachmerth commented Dec 19, 2025

Uh oh!

hsd-problem-testing Bot commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem Summary: 72 total

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

hsd-problem-testing Bot commented Dec 19, 2025 •

edited

Loading