Skip to content

Linked lists#63

Merged
MMachmerth merged 17 commits into
adg2025from
LinkedLists
Dec 22, 2025
Merged

Linked lists#63
MMachmerth merged 17 commits into
adg2025from
LinkedLists

Conversation

@MMachmerth
Copy link
Copy Markdown
Contributor

No description provided.

@hsd-problem-testing
Copy link
Copy Markdown

hsd-problem-testing Bot commented Dec 22, 2025

Problem Solution Type Status Message
binary invalid_1 invalid
binary invalid_2 invalid
binary valid_1 valid
binary valid_2 valid
bogo invalid_1 invalid
bogo invalid_2 invalid
bogo invalid_3 invalid
bogo valid_1 valid
bubble invalid_1 invalid
bubble invalid_2 invalid
bubble invalid_3 invalid
bubble valid_1 valid
divide-integers alt_1 valid
divide-integers alt_2 valid
divide-integers invalid_1 invalid
divide-integers invalid_2 invalid
divide-integers invalid_3 invalid
einsen valid_1 valid
einstein alt_1 valid
emojize alt_1 valid
emojize alt_2 valid
emojize invalid_1 invalid
extensions alt_1 valid
extensions alt_2 valid
faces alt_1 valid
hackers valid_1 valid
hello alt_1 valid
iban valid_1 valid
insert invalid_1 invalid
insert valid_1 valid
interpreter valid_1 valid
intervals invalid_1 invalid
intervals valid_1 valid
linear valid_1 valid
linear valid_2 valid
linkedAfter valid_1 valid
linkedFind valid_1 valid
linkedInsert valid_1 valid
linkedMerge valid_1 valid
linkedRemove valid_1 valid
linkedStack valid_1 valid
luhn valid_1 valid
merge invalid_1 invalid
merge invalid_2 invalid
merge invalid_3 invalid
merge invalid_4 invalid
merge valid_1 valid
merge valid_2 valid
merge valid_3 valid
merge valid_4 valid
nadel alt_1 valid
neuner ⚠️
ReasonNo tests found
palindrom invalid_1 invalid
palindrom valid_1 valid
playback alt_1 valid
rotate invalid_1 invalid
rotate valid_1 valid
rotate valid_2 valid
rotate valid_3 valid
rotate valid_4 valid
run_back invalid_1 invalid
run_back invalid_2 invalid
run_back invalid_3 invalid
run_back valid_1 valid
strings alt_1 valid
stufen valid_1 valid
stufen valid_2 valid
sudoku1 valid_1 valid
sudoku1 valid_2 valid
sudoku1 valid_3 valid
sudoku2 valid_1 valid
tip alt_1 valid
willkommen alt_1 valid
zahlenjagd alt_1 valid
zeilen invalid_1 invalid
zeilen invalid_2 invalid
zeilen valid_1 valid
zeilen valid_2 valid

Problem Summary: 78 total

✅ Passed: 77
🔴 Failed: 0
⚠️ Warnings: 1

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a comprehensive suite of linked list exercises to support data structures and algorithms curriculum. The PR also includes minor corrections to existing exercises.

Key Changes

  • Six new linked list exercises with complete HTML documentation, test suites, and configuration files
  • Enhanced test coverage for the rotate exercise with in-place modification checks
  • Corrections to IBAN exercise (expected values and spelling)
  • Spelling fixes in Sudoku2 exercise documentation

Reviewed changes

Copilot reviewed 38 out of 46 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
linkedStack/* New exercise: Implement a stack data structure using a linked list with push, pop, and peek operations
linkedRemove/* New exercise: Remove a specific element from a linked list
linkedMerge/* New exercise: Merge two sorted linked lists into one sorted list
linkedInsert/* New exercise: Insert a new node at the end of a linked list
linkedFind/* New exercise: Search for a value in a linked list and return the node
linkedAfter/* New exercise: Insert a new node after a specific node in a linked list
zeilen/checks/main.py Added two additional test cases for rowMult function (examples 3 and 4)
sudoku2/html/* Fixed spelling errors (Suduko→Sudoku) and updated function name references from isValid to isValidBlock
iban/html/* Corrected expected check digit value (23→27) and fixed grammar errors
rotate/checks/main.py Enhanced tests to verify in-place list modification behavior

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +29 to +35
def a(self, b):
c = self.head
while c is not None:
if c.value == b:
return c
c = c.next
return None
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The helper function 'a' has a non-descriptive single-letter name that makes the code difficult to understand. This appears to be implementing searchValue functionality but should have a meaningful name like 'search_value_for_test' or similar to clarify its purpose in the test suite.

Copilot uses AI. Check for mistakes.
Comment on lines +29 to +34
def a(self, b):
c = self.head
while c is not None:
if c.value == b:
return c
c = c.next
Copy link

Copilot AI Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The function parameter names 'b' and 'c' are non-descriptive single-letter names. Consider using meaningful names like 'value' for the parameter being searched and 'current' for the traversal variable to improve code readability.

Suggested change
def a(self, b):
c = self.head
while c is not None:
if c.value == b:
return c
c = c.next
def a(self, value):
current = self.head
while current is not None:
if current.value == value:
return current
current = current.next

Copilot uses AI. Check for mistakes.
Comment thread linkedAfter/checks/main.py Outdated
@MMachmerth MMachmerth merged commit 1f2c5e7 into adg2025 Dec 22, 2025
2 checks passed
@MMachmerth MMachmerth deleted the LinkedLists branch December 22, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants