Skip to content

Add shelter number #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 31, 2025
Merged

Add shelter number #1052

merged 3 commits into from
Mar 31, 2025

Conversation

suvikankare
Copy link
Contributor

@suvikankare suvikankare commented Mar 28, 2025

This change is Reviewable

@suvikankare suvikankare changed the title DRAFT: Shelter number Shelter number Mar 28, 2025
@suvikankare suvikankare changed the title Shelter number Add shelter number Mar 28, 2025
@suvikankare suvikankare marked this pull request as ready for review March 28, 2025 07:59
Copy link
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @suvikankare)


ui/src/components/stop-registry/stops/stop-details/stop-version/utils/useCopyStop.ts line 220 at r1 (raw file):

      }

      const shelterResolver = await getShelterResolver(quayId);

Ton ShelterResolver luokan vois varmaan kokonaan poistaa ja getShelterResolver:in uudelleen nimetä ja muuttaa palauttaan vaan suoraan listana ne katokset.


ui/src/components/stop-registry/stops/stop-details/shelters/ShelterFormFields.tsx line 59 at r1 (raw file):

  useEffect(() => {
    if (currentShelterNumber === null) {
      const nextNumber =
Math.max(...allShelters.map(it => Number(it.shelterNumber))

Copy link
Contributor

@Huulivoide Huulivoide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @suvikankare)

@suvikankare suvikankare merged commit 13dd9f1 into main Mar 31, 2025
10 checks passed
@suvikankare suvikankare deleted the shelter-number branch March 31, 2025 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants