Csv export #1226
Merged
Csv export #1226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suvikankare
reviewed
Oct 23, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 12 files reviewed, 1 unresolved discussion
ui/src/time.ts line 69 at r1 (raw file):
// "shorTime" means format "H.mm" export const mapToShorTime = (date?: DateLike | null) =>
typo funktion nimessä
Huulivoide
force-pushed
the
csv-export
branch
2 times, most recently
from
20ffafa to
d411be4
Compare
Huulivoide
commented
Oct 23, 2025
There was a problem hiding this comment.
Reviewable status: 0 of 15 files reviewed, 1 unresolved discussion (waiting on @suvikankare)
ui/src/time.ts line 69 at r1 (raw file):
Previously, suvikankare wrote…
typo funktion nimessä
Tämä fiksattu ja testit muutettu toimimaan myöskin github testi ajossa.
suvikankare
approved these changes
Oct 24, 2025
There was a problem hiding this comment.
@suvikankare reviewed 6 of 12 files at r1, 9 of 9 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Huulivoide)
Huulivoide
force-pushed
the
csv-export
branch
from
d411be4 to
88bfcae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow formatting short time only
ToastService: Allow ReactNode as message for all helpers
Add CSVWriter class
Add simple CSV download button demo
E2E: Test StopSearch CSV generation
This change is