Skip to content
This repository has been archived by the owner on Dec 18, 2024. It is now read-only.

1-based index in all.requests #270

Merged
merged 1 commit into from
Aug 6, 2024
Merged

1-based index in all.requests #270

merged 1 commit into from
Aug 6, 2024

Conversation

max-ostapenko
Copy link
Contributor

@max-ostapenko max-ostapenko commented Aug 5, 2024

From the first glance it seems to me as a simple error in column description.

  1. see line here

  2. Query returns no results:

SELECT
  url,
  index,
  type,
  is_main_document,
  page
FROM `httparchive.all.requests`
WHERE
  date = '2024-06-01'
  AND client = 'mobile'
  AND is_root_page = TRUE
  AND index = 1

Please let me know if we actually expect a 0-based index.

Need to fix here too: https://har.fyi/reference/tables/requests/#index

Copy link
Contributor

github-actions bot commented Aug 5, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@rviscomi rviscomi merged commit 70bc8d7 into HTTPArchive:main Aug 6, 2024
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants