Remove Amplitude and Amazon Payments from client - #15693
Open
SabreCat wants to merge 4 commits into
Open
Conversation
SabreCat
marked this pull request as draft
August 7, 2026 19:00
SabreCat
marked this pull request as ready for review
August 7, 2026 19:13
Hafizzle
requested changes
Aug 7, 2026
Hafizzle
left a comment
Hafizzle
left a comment
Contributor
There was a problem hiding this comment.
The removal all looks good, also verified no dangling references of the deleted files.
please correct me if I'm wrong, but I think this breaks cancellation for existing Amazon subscribers:
website/client/src/mixins/payments.js
paymentMethod = paymentMethod.toLowerCase();
const cancelUrl = `/${paymentMethod}/subscribe/cancel?${encodeParams(queryParams)}`;
For Amazon subscribers, paymentMethod is "Amazon Payments". Lowercasing it gives "amazon payments" so the request goes to /amazon payments/subscribe/cancel and 404s I think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When auditing our cookies usage for privacy updates, we discovered Amplitude and Amazon Payments cookies still appearing. We don't use either of those client libraries anymore, so we can get rid of them.