DARYNA_TKACHENKO-w2-UsingAPIs #16
Open
dashaaaa21 wants to merge 1 commit intoHackYourAssignment:mainfrom
Open
Conversation
codethenpizza
approved these changes
Oct 13, 2025
| function fetchAndPopulatePokemons(/* TODO parameter(s) go here */) { | ||
| // TODO complete this function | ||
| async function fetchAndPopulatePokemons() { | ||
| const url = 'https://pokeapi.co/api/v2/pokemon?limit=150'; |
There was a problem hiding this comment.
love it!
It's really good practice to keep such things in separate variables and not define them right in the functions like this: fetchData('https://pokeapi.co/api/v2/pokemon?limit=151');
Great that you did it!
| ); | ||
| renderLaureates(laureates); | ||
|
|
||
| if (Array.isArray(data.laureates)) { |
There was a problem hiding this comment.
It's good to make sure it's safe, but in this case, it might be redundant as it seems like the API always returns an array, even when the params are wrong, like unknown country
You don't need to make any changes, just wanted to highlight it
| return rollDie().then((value) => { | ||
| if (value !== desiredValue) { | ||
| return rollDieUntil(desiredValue); | ||
| export async function rollDieUntil(desiredValue: DieFace): Promise<DieFace> { |
There was a problem hiding this comment.
Is it something you uploaded by accident?
Author
|
Thank you so much for reviewing my work and for your time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.