DARYNA-TKACHENKO-WEEK2-REACT#14
Open
dashaaaa21 wants to merge 9 commits intoHackYourAssignment:mainfrom
Open
Conversation
sycons
approved these changes
Dec 28, 2025
sycons
left a comment
sycons
left a comment
There was a problem hiding this comment.
Following were implemented:
fake-datadirectory is no longer used ✅- App connects to endpoints in the API to fetch data for categories and products ✅
- Filter the products in the API and not in the frontend ✅
- App displays loading when waiting for request to complete fetching data ✅
- App shows an error message if the request failed ✅
- Clicking on product card goes to a detail page ✅
- Detail page fetches data from an endpoint ✅
- Deploy app somewhere (like netlify) and add link to PR ✅
Great job! Added some comments on details I noticed. Your UI is responsive and sleek and you add UX touches that are really nice.
Well done on structuring your app by separating out pages and services.
| }; | ||
|
|
||
| export const fetchProducts = async (category = null) => { | ||
| const url = category |
There was a problem hiding this comment.
Clever implementation to use an optional parameter to determine the URL ⭐
| d="M15 19l-7-7 7-7" | ||
| /> | ||
| </svg> | ||
| Back to Products |
sycons
reviewed
Dec 28, 2025
|
|
||
| useEffect(() => { | ||
| loadProducts(); | ||
| }, [selectedCategory]); |
There was a problem hiding this comment.
OPTIONAL: Fix linting warning React Hook useEffect has a missing dependency: 'loadProducts'. Either include it or remove the dependency array. You can run npm run lint to see this warning. Fixing this will provide a deeper understanding of the useEffect hook.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.